[plugins] Add marketplace source requirements#29690
Conversation
74505d8 to
2917cca
Compare
2917cca to
cf169c5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2917cca2e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cf169c5 to
712d186
Compare
712d186 to
a749876
Compare
a749876 to
b6afbd3
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6afbd3625
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b6afbd3 to
730a101
Compare
|
@codex review again |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Why
Managed deployments need a mergeable way to declare which marketplace sources Codex may use. An enterprise-keyed TOML table avoids array merge ambiguity and lets every requirements layer use the existing config precedence rules without a marketplace-specific merger.
Requirements shape
restrict_to_allowed_sourcesfollows normal scalar precedence.allowed_sourcesfollows normal recursive TOML table merge behavior: distinct keys accumulate and fields under the same key use normal layer precedence. The finalsourcevalue later selects which fields the marketplace admission policy interprets.The raw rule fields remain optional while requirements layers are composed, so a higher-priority layer can override only
ref,url, or another individual field. Source-specific validation and normalization intentionally belong to the marketplace admission layer, not requirements merging.This initial shape includes
git,host_pattern, andlocalsources. It does not add npm or path-pattern rules.What changed
ConfigRequirementsToml,ConfigRequirementsWithSources, andConfigRequirements.This PR defines and composes the requirements only. Source admission is implemented by the next PR in the stack.
Stack
This is PR 1 of 3. #29753 adds source admission on top of this PR; draft #29691 will add runtime enforcement after it is rebased later.
Test plan
just test -p codex-config marketplace_