Allow codex sandbox to consume MCP sandbox state#29358
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8cf5d7bd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b8cf5d7 to
88e7722
Compare
2451657 to
2a60a19
Compare
This was referenced Jun 22, 2026
b6de8dc to
9735c6e
Compare
Base automatically changed from
jif/remote-exec-server-sandbox-enforcement
to
main
June 22, 2026 10:45
9735c6e to
6fe4c88
Compare
anp-oai
reviewed
Jun 22, 2026
anp-oai
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex sandboxaccept the JSON value fromcodex/sandbox-state-metapermissionProfileinstead of falling back to ambient permissionsBuilds on #29113, which is now on
main.Tests
just test -p codex-cli debug_sandbox::testscargo build -p codex-rmcp-client --bin test_stdio_serverjust test -p codex-core stdio_mcp_tool_call_includes_sandbox_state_metajust test -p codex-mcpjust fmt