[codex] Assign response item IDs when recording history by pakrym-oai · Pull Request #28814 · openai/codex

pakrym-oai · 2026-06-17T23:44:19Z

Why

Client-created response items enter history without IDs, so their identity is lost across rollout persistence and resume. IDs should be assigned once at the history-recording boundary, while IDs returned by the server must remain unchanged.

The Responses API validates item IDs using type-specific prefixes. Locally generated IDs therefore use the matching prefix plus a hyphenated UUIDv7, keeping them valid while distinguishable from server-generated IDs. Because this changes persisted history and provider request shapes, the behavior is opt-in behind the under-development item_ids feature. Compaction triggers remain request controls whose API shape does not accept an ID.

What changed

Register the disabled-by-default item_ids feature and expose it in config.schema.json.
Make supported optional ResponseItem IDs serializable and expose them in the generated app-server schemas.
When item_ids is enabled, assign an ID during conversation-history preparation if an item has no ID.
Generate type-prefixed, hyphenated UUIDv7 IDs using the Responses API item conventions.
Preserve existing server IDs without rewriting them.
Persist assigned IDs in rollouts and include them in subsequent Responses requests.
Remove the unsupported ID field from CompactionTrigger and document why it has no ID.
Add integration coverage for enabled ID persistence, preservation of server IDs, and omission of generated IDs while the feature is disabled.

prepare_conversation_items_for_history is the single response-item ID allocation boundary.

Test plan

just test -p codex-features
just test -p codex-core response_item_ids_persist_across_resume_and_preserve_server_ids
just test -p codex-core non_openai_responses_requests_omit_item_turn_metadata
just test -p codex-core resize_all_images_prepares_failures_before_history_insertion
just test -p codex-protocol
just test -p codex-app-server-protocol
just test -p codex-api azure_default_store_attaches_ids_and_headers

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd681791d8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

pakrym-oai · 2026-06-18T16:06:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 009bd870cd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-18T16:13:55Z

+                ResponseItem::LocalShellCall { .. } => "lsh",
+                ResponseItem::FunctionCall { .. } => "fc",
+                ResponseItem::ToolSearchCall { .. } => "tsc",
+                ResponseItem::FunctionCallOutput { .. } => "fco",


Use the Responses prefix for function output IDs

When item_ids is enabled and any function/tool result is recorded, this branch generates IDs like fco_<uuid> for function_call_output items. The Responses API uses the fc_... item-id shape for function tool call outputs and validates item IDs by type, so the next request after a tool call can be rejected solely because Codex minted an invalid output item ID; use the provider-accepted prefix here instead of the invented fco prefix.

Useful? React with 👍 / 👎.

fco_ is fine.

pakrym-oai · 2026-06-18T21:04:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 949475bda2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-18T21:09:26Z

+        if !include_item_ids {
+            strip_response_item_ids(&mut body);


Preserve Azure store item IDs by default

When using the Azure Responses endpoint, ModelClient::build_responses_request still sets store to true for every request, but include_item_ids is false unless the new under-development item_ids feature is enabled. This unconditional strip therefore removes IDs from the default Azure stored-history path; before this change the request.store && is_azure_responses_endpoint() branch specifically re-attached those IDs, so Azure continuation/store requests lose the item identifiers unless users opt into an unrelated rollout flag.

Useful? React with 👍 / 👎.

pakrym-oai · 2026-06-18T22:31:50Z

@codex review

chatgpt-codex-connector · 2026-06-18T22:36:14Z

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 5233e4da7d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

rka-oai · 2026-06-19T00:21:40Z


-    /// Sets the Responses API item ID for variants that carry one.
-    pub fn set_id(&mut self, new_id: String) {
+    /// Sets or clears the Responses API item ID for variants that carry one.


whats the point of ever stripping all the items on a request (by calling set_id None?)

i guess it doesn't really matter though, the functionality is fine to have (and maybe some providers don't support the ID?)

I want to re-enable this for everyone but we had it disabled for a bit (because having IDs cause Responses API to try and load the item).

Base automatically changed from pakrym/response-item-id-fields to main June 18, 2026 01:27

pakrym-oai force-pushed the pakrym/response-item-ids-on-history branch 3 times, most recently from 7acd80a to bd68179 Compare June 18, 2026 01:53

pakrym-oai marked this pull request as ready for review June 18, 2026 01:57

pakrym-oai requested a review from a team as a code owner June 18, 2026 01:57

chatgpt-codex-connector Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread codex-rs/core/src/session/mod.rs Outdated

Comment thread codex-rs/protocol/src/models.rs

Comment thread codex-rs/protocol/src/models.rs

pakrym-oai force-pushed the pakrym/response-item-ids-on-history branch 2 times, most recently from 2cf87aa to 4966ca6 Compare June 18, 2026 02:30

assign response item IDs when recording history

009bd87

pakrym-oai force-pushed the pakrym/response-item-ids-on-history branch from 4966ca6 to 009bd87 Compare June 18, 2026 04:21

chatgpt-codex-connector Bot reviewed Jun 18, 2026

View reviewed changes

pakrym-oai force-pushed the pakrym/response-item-ids-on-history branch from 6d33e10 to 009bd87 Compare June 18, 2026 16:27

pakrym-oai added 9 commits June 18, 2026 11:01

codex: address PR review feedback (#28814)

c2b77d7

codex: preserve legacy image generation IDs (#28814)

9d198cf

codex: keep item ID serialization unconditional (#28814)

f2e69e5

codex: update item ID fixtures (#28814)

2ea01cc

codex: defer inter-agent item IDs (#28814)

20d146f

Gate response item IDs in outbound requests

92d942d

codex: fix CI failure on PR #28814

a5cd238

codex: update default item ID expectations

de68ecb

codex: omit IDs from default history fixture

949475b

chatgpt-codex-connector Bot reviewed Jun 18, 2026

View reviewed changes

pakrym-oai added 4 commits June 18, 2026 14:26

codex: address PR review feedback (#28814)

f5750e7

codex: preserve IDs for stored requests

1abdae4

codex: centralize response item ID request policy

d5070ac

codex: fix CI failure on PR #28814

5233e4d

rka-oai reviewed Jun 19, 2026

View reviewed changes

rka-oai approved these changes Jun 19, 2026

View reviewed changes

pakrym-oai merged commit f00f93d into main Jun 19, 2026
45 of 47 checks passed

pakrym-oai deleted the pakrym/response-item-ids-on-history branch June 19, 2026 00:30

github-actions Bot locked and limited conversation to collaborators Jun 19, 2026

Uh oh!

Conversation

pakrym-oai commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What changed

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pakrym-oai commented Jun 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

pakrym-oai Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

pakrym-oai commented Jun 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pakrym-oai commented Jun 18, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 18, 2026

Uh oh!

rka-oai Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

rka-oai Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

pakrym-oai Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pakrym-oai commented Jun 17, 2026 •

edited

Loading