recover stale Windows sandbox credentials#27944
Merged
Merged
Conversation
f4e4c56 to
35ebd05
Compare
zm-oai
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The elevated Windows sandbox persists dedicated sandbox account credentials so later commands can launch without reprovisioning. If those persisted credentials drift from the actual Windows account password,
CreateProcessWithLogonWfails withERROR_LOGON_FAILUREand Codex currently surfaces that as a hard runner launch failure.This change makes that failure self-healing. When Windows specifically rejects the sandbox login, Codex now treats the persisted sandbox credentials as stale, regenerates them through the existing setup path, and retries the runner launch once.
What Changed
CreateProcessWithLogonWfailures as a typed runner logon error so callers can distinguishERROR_LOGON_FAILUREfrom unrelated launch failures.sandbox_users.jsonrecord and reusesrequire_logon_sandbox_creds()to reprovision credentials through the established setup flow.Validation
git diff --checkcargo test -p codex-windows-sandbox