Skip to content

Use aws-lc-rs for rustls crypto provider#27706

Merged
malsamiri-oai merged 1 commit into
mainfrom
codex/se-6797-aws-lc-rustls-provider
Jun 15, 2026
Merged

Use aws-lc-rs for rustls crypto provider#27706
malsamiri-oai merged 1 commit into
mainfrom
codex/se-6797-aws-lc-rustls-provider

Conversation

@malsamiri-oai

@malsamiri-oai malsamiri-oai commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Why

Some enterprise TLS proxies issue certificate chains signed with ecdsa_secp521r1_sha512 / ECDSA_NISTP521_SHA512. Custom CA configuration such as SSL_CERT_FILE can add the right trust root, but it cannot make rustls's ring verifier support a certificate signature algorithm it does not advertise.

That can still break TLS after the CA bundle is configured, including on Rust websocket paths that call the shared ensure_rustls_crypto_provider() helper, such as the Responses websocket connector and remote app-server client:

The aws-lc-rs rustls provider supports this P-521/SHA-512 certificate signature scheme, so use it as Codex's process-wide rustls provider.

What Changed

  • Switch the workspace rustls feature from ring to aws_lc_rs.
  • Update codex-utils-rustls-provider to install rustls::crypto::aws_lc_rs::default_provider().
  • Add an assertion and integration test that the installed provider supports ECDSA_NISTP521_SHA512.

Verification

just fmt
just test -p codex-utils-rustls-provider
just bazel-lock-update
just bazel-lock-check

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@malsamiri-oai malsamiri-oai changed the title Use aws-lc-rs rustls provider Use aws-lc-rs for rustls crypto provider Jun 11, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8135b99cfc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/Cargo.toml
Comment thread codex-rs/utils/rustls-provider/src/lib.rs Outdated
@malsamiri-oai malsamiri-oai force-pushed the codex/se-6797-aws-lc-rustls-provider branch from 8135b99 to a4efc30 Compare June 11, 2026 23:50
@malsamiri-oai

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@malsamiri-oai malsamiri-oai force-pushed the codex/se-6797-aws-lc-rustls-provider branch from a4efc30 to ecbee60 Compare June 12, 2026 00:07
github-actions Bot added a commit that referenced this pull request Jun 12, 2026
@malsamiri-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecbee60436

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/utils/rustls-provider/src/lib.rs Outdated
Comment thread codex-rs/Cargo.toml
@malsamiri-oai malsamiri-oai force-pushed the codex/se-6797-aws-lc-rustls-provider branch from ecbee60 to 4133ae0 Compare June 12, 2026 01:01
@malsamiri-oai malsamiri-oai enabled auto-merge (squash) June 12, 2026 19:33
@malsamiri-oai malsamiri-oai merged commit d5a8117 into main Jun 15, 2026
73 of 78 checks passed
@malsamiri-oai malsamiri-oai deleted the codex/se-6797-aws-lc-rustls-provider branch June 15, 2026 18:32
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants