TUI Plugin Sharing 3 - render remote plugin catalog sections#26703
Conversation
c3c2f07 to
9d73059
Compare
8798c0c to
834ca6a
Compare
a339783 to
4f34643
Compare
ba4dd5b to
34ba4ee
Compare
b529f33 to
5d54c4e
Compare
34ba4ee to
40f1ca8
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40f1ca88d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
40f1ca8 to
f7b6f35
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 266578c676
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc5d9cb237
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3e591c2 to
ce95121
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c823a78092
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a5191fcb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Self::OpenAiCurated => Some("OpenAI Curated"), | ||
| Self::Workspace => Some("Workspace"), | ||
| Self::SharedWithMe => Some("Shared with me"), | ||
| Self::SharedWithMeLink => Some("Shared with me (link)"), |
There was a problem hiding this comment.
Our design on Codex App is to hide Shared with me (link) unless it is installed. But I guess it is more hard to implement in CLI, could be a fast follow.
Summary
#26701 added remote plugin identity support, #26702 added remote-section fetching and state, and #28768 extracted the catalog rendering module. This PR builds the product-facing
/pluginscatalog on that foundation so remote records appear as OpenAI Curated, Workspace, and Shared with me sections rather than backend marketplace implementation details.Plugin details remain read-only for sharing metadata. This PR does not add share-authoring actions or change the app-server protocol.
Changes
Tests
New tests:
plugins_popup_admin_disabled_available_plugin_has_view_only_hintplugins_popup_remote_section_fallback_states_snapshotplugins_popup_installed_remote_row_keeps_remote_detail_when_local_share_is_uninstalledUpdated existing plugin catalog tests and snapshots for product labels, detail metadata, personal-marketplace labeling, and stable tab ordering.
Verification:
cargo clippy -p codex-tui --all-targets -- -D warningsFollow-ups