Skip to content

Nicer highlighting of slash commands, /plan accepts prompt args and pasted images#10269

Merged
charley-oai merged 10 commits into
mainfrom
slash-plan-with-args
Feb 2, 2026
Merged

Nicer highlighting of slash commands, /plan accepts prompt args and pasted images#10269
charley-oai merged 10 commits into
mainfrom
slash-plan-with-args

Conversation

@charley-oai

@charley-oai charley-oai commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Make typed slash commands become text elements when the user hits space, including paste‑burst spaces.
  • Enable /plan to accept inline args and submit them in plan mode, mirroring /review behavior and blocking submission while a task is
    running.
  • Preserve text elements/attachments for slash commands that take args.
image

Changes

  • Add safe helper to insert element ranges in the textarea.
  • Extend command‑with‑args pipeline to carry text elements and reuse submission prep.
  • Update /plan dispatch to switch to plan mode then submit prompt + elements.
  • Document new composer behavior and add tests.

Notes

  • /plan is blocked during active tasks (same as /review).
  • Slash‑command elementization recognizes built‑ins and /prompts: custom commands only.

Codex author

codex fork 019c16d3-4520-7bb0-9b9d-48720d40a8ab

@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5f1f79a77

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs Outdated

@charley-oai charley-oai left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai marked this pull request as ready for review February 1, 2026 08:24
@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81a82b7e21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs
@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai changed the title Enable /plan arg hint, inline element, and fast submit flow Nicer highlighting of slash commands, /plan accepts prompt args Feb 1, 2026
@charley-oai charley-oai changed the title Nicer highlighting of slash commands, /plan accepts prompt args Nicer highlighting of slash commands, /plan accepts prompt args, slash commands accept pasted image args Feb 1, 2026
@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@charley-oai charley-oai changed the title Nicer highlighting of slash commands, /plan accepts prompt args, slash commands accept pasted image args Nicer highlighting of slash commands, /plan accepts prompt args and pasted images Feb 2, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai merged commit 3392c5a into main Feb 2, 2026
32 checks passed
@charley-oai charley-oai deleted the slash-plan-with-args branch February 2, 2026 17:53
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants