Warning message Option BackUp before Update#1609
Merged
LKuemmel merged 4 commits intoopenWB:masterfrom May 8, 2024
Merged
Conversation
LKuemmel
requested changes
May 8, 2024
packages/helpermodules/command.py
Outdated
Comment on lines
+684
to
+686
| if SubData.system_data["system"].data["backup_before_update"]: | ||
| pub_user_message(payload, connection_id, "Fehler beim BackUp erstellen<br />Fahre mit Update fort...", | ||
| MessageType.WARNING) |
Contributor
There was a problem hiding this comment.
In Z 638 muss die Exception abgefangen werden, sonst wird die Durchführung des Updates trotzdem abgebrochen:
try:
self.createCloudBackup(connection_id, {})
except Exception:
pub_user_message(payload, connection_id, ("Fehler beim Erstellen der Cloud-Sicherung."
f" {traceback.format_exc()}<br />Fahre mit Update fort..."),
MessageType.WARNING)
In Z 692 kann die Meldung noch um einen Hinweis ergänzt werden:
pub_user_message(payload, connection_id, ("Backup wird erstellt. Dieser Vorgang kann je nach Umfang der "
"Logdaten und Upload-Geschwindigkeit des Cloud-Dienstes einige Zeit in Anspruch nehmen."),
MessageType.INFO)
pama87
force-pushed
the
master
branch
2 times, most recently
from
45cdd4a to
fc25f38
Compare
LKuemmel
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.