Merged
Conversation
tpd-opitz
reviewed
Mar 15, 2024
| convert_file(file) | ||
| self.__update_topic("openWB/system/datastore_version", 38) | ||
|
|
||
| def upgrade_datastore_38(self) -> None: |
Contributor
There was a problem hiding this comment.
Sollte der Suffix nicht auch angepasst werden? Falls nicht, sollte man ihn dann nicht ganz abschaffen?
Contributor
There was a problem hiding this comment.
Was meinst Du genau mit "Suffix"?
benderl
reviewed
Mar 22, 2024
Comment on lines
+118
to
+123
| def get_value_or_default(func): | ||
| try: | ||
| return func() | ||
| except Exception: | ||
| log.exception(f"Error getting value für chargelog: {func}. Setting to default.") | ||
| return "-" |
Contributor
There was a problem hiding this comment.
Suggested change
| def get_value_or_default(func): | |
| try: | |
| return func() | |
| except Exception: | |
| log.exception(f"Error getting value für chargelog: {func}. Setting to default.") | |
| return "-" | |
| def get_value_or_default(func, default_value = "-"): | |
| try: | |
| return func() | |
| except Exception: | |
| log.exception(f"Error getting value for chargelog: {func}. Setting to default.") | |
| return default_value |
Wenn man den Standardwert übergeben kann, wird die Methode wesentlich vielseitiger nutzbar.
In dem Zuge sollte überdacht werden, ob - ein sinnvoller Standardwert für eine Variable ist, die eigentlich eine Zahl ist. Für "undefiniert" oder "ungültig" würde ich eher None verwenden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.