Conversation
for openssl 3.3
Merged
m-kuhn
force-pushed
the
bump-python-3-11-9
branch
from
fa2b164 to
2f3e74f
Compare
m-kuhn
force-pushed
the
bump-python-3-11-9
branch
3 times, most recently
from
4776ff1 to
86778a2
Compare
Neumann-A
reviewed
May 12, 2024
| vcpkg_from_pythonhosted( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| PACKAGE_NAME PyQt-builder | ||
| FILE_NAME pyqt_builder |
Member
There was a problem hiding this comment.
just calculated a filename from package_name ?
Contributor
Author
There was a problem hiding this comment.
I assume you meant to say "just calculate" without "d".
Compare https://pypi.org/project/PyQt-builder/1.16.2/#files and https://pypi.org/project/PyQt-builder/1.15.4/#files the filenames do not follow a rule. For the standard case following naming conventions FILE_NAME is not required though https://github.com/open-vcpkg/python-registry/pull/29/files#diff-296f6707a6a059f9b1531dcfb0d9038a4d02b772d8e8c4581b5fdf6daf9a44a7R24-R26
m-kuhn
force-pushed
the
bump-python-3-11-9
branch
from
86778a2 to
5a50b44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python 3.11.9 requires openssl 3.3 which requires a baseline update which brings Qt 6.7.0 which requires PyQt 6.7.0 which requires sip, pyqt-builder and sip-pyqt6 updates
Additionally, pyqt-builder artifact filenames are unstable