Conversation
|
|
||
| trace.set_preferred_tracer_implementation(lambda T: Tracer()) | ||
| tracer = trace.tracer() | ||
| with tracer.start_span('foo'): |
There was a problem hiding this comment.
what is the expected behavior when one starts a span with the same name? it looks like it'll override the current span, which means that it will proceed to replace the contents of the outer span of the same name.
side question: are named spans valuable?
There was a problem hiding this comment.
what is the expected behavior when one starts a span with the same name? it looks like it'll override the current span, which means that it will proceed to replace the contents of the outer span of the same name.
It will just work. What we put in the context is the span instead of the name. name doesn't matter.
side question: are named spans valuable?
Definitely YES! Span name is actually the operation name (or the name you see from the Gantt Chart).
|
@a-feld @carlosalberto @lzchen @Oberon00 @toumorokoshi can we have another approval please? :) |
|
Sure, I'll take a look later this morning! |
opentelemetry.contextfrom tracer.Part of the effort for #22.