Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
=========================================
- Coverage 85.27% 85.18% -0.1%
=========================================
Files 38 38
Lines 1956 1937 -19
Branches 231 230 -1
=========================================
- Hits 1668 1650 -18
Misses 221 221
+ Partials 67 66 -1
Continue to review full report at Codecov.
|
Member
Author
|
Looking back at #95, it's not clear why we're using Not as satisfying as solving the actual underlying travis issue, but we can unblock builds with this PR now and revisit if we have a reason to target |
codeboten
approved these changes
Feb 11, 2020
Contributor
codeboten
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing this
Member
Author
|
Entering god mode to merge and unblock builds. |
toumorokoshi
pushed a commit
to toumorokoshi/opentelemetry-python
that referenced
this pull request
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of pypy3.5, debugging #406.
Fixes #406.