Change imports to avoid pylint namespace errors#376
Change imports to avoid pylint namespace errors#376c24t merged 2 commits intoopen-telemetry:masterfrom
Conversation
This reverts commit 5a224ad.
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 85.08% 85.22% +0.14%
==========================================
Files 38 38
Lines 1897 1916 +19
Branches 225 226 +1
==========================================
+ Hits 1614 1633 +19
Misses 218 218
Partials 65 65
Continue to review full report at Codecov.
|
mauriciovasquezbernal
left a comment
There was a problem hiding this comment.
I tried it on top of #282 (after reverting the previous changes to avoid these errors) and it works good.
|
|
I think that's exactly what's happening. On 5a224ad Worse, it looks like this happens on class name collisions too. AFAICT lint fails on fec0fbe because |
This is
9d3ef06dsplit off from #282 at @mauriciovasquezbernal's request.See #282 (comment).
Edit: changed to use
pylint:ignore=no-memberin the modules failing lint instead. These errors are almost never meaningful, and this prevents us from having to play type inference whack-a-mole in the future if these imports change.