test fix: removing use of ABC Span in API test#375
Merged
c24t merged 1 commit intoopen-telemetry:masterfrom Jan 23, 2020
Merged
test fix: removing use of ABC Span in API test#375c24t merged 1 commit intoopen-telemetry:masterfrom
c24t merged 1 commit intoopen-telemetry:masterfrom
Conversation
There was one instance of using an ABC Span object in the unit tests, which is breaking linting and typing.
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=========================================
Coverage ? 85.22%
=========================================
Files ? 38
Lines ? 1916
Branches ? 226
=========================================
Hits ? 1633
Misses ? 218
Partials ? 65Continue to review full report at Codecov.
|
codeboten
approved these changes
Jan 23, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for catching this.
c24t
approved these changes
Jan 23, 2020
toumorokoshi
added a commit
to toumorokoshi/opentelemetry-python
that referenced
this pull request
Feb 17, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat(plugin-https): patch https requests closes open-telemetry#375 add tests Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * docs(plugin-https): add jaeger image Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add mayurkale22 recommendations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add markwolff recommendations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: file name utils * fix: add danielkhan and bg451 recommendations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was one instance of using an ABC Span object
in the unit tests, which is breaking linting and typing.