Fix dependencies for test utils#2587
Merged
lzchen merged 4 commits intoopen-telemetry:mainfrom Apr 4, 2022
Merged
Conversation
codeboten
reviewed
Apr 4, 2022
codeboten
approved these changes
Apr 4, 2022
srikanthccv
approved these changes
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing
flaskas a dependency fortest-utils. This was left in from a previous PR but is no longer needed since we define dependencies for the flask instrumentation here andtest-utilsitself does not useflask.Adding
asgirefas a dependency fortest-utilsbecause it uses that library. Previous builds have passed because the tests that useasgirefare only in the asgi instrumentation and it has a dependency on asgiref already defined.Also pinning
protobufversion for now since upgrading to protobuf v3.20.0 causes lint to fail.Opened an issue on protobuf.