fix(instr-redis): don't fail commands when connection pool lacks connection_kwargs#4782
Merged
xrmx merged 2 commits intoJul 10, 2026
Conversation
MikeGoldsmith
approved these changes
Jul 9, 2026
herin049
approved these changes
Jul 9, 2026
xrmx
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Redis cluster clients can expose a
connection_poolobject that doesn't haveconnection_kwargs. Current instrumentation only checked for existence ofconnection_pooland would raise anAttributeErrorifconnection_kwargsdidn't exist. This change checks for the existence ofconnection_kwargsand skips adding those attributes if they are not available.Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.