Skip to content

TracerProvider: Make format settable.#914

Closed
Oberon00 wants to merge 1 commit intoopen-telemetry:masterfrom
dynatrace-oss-contrib:feature/settable-format
Closed

TracerProvider: Make format settable.#914
Oberon00 wants to merge 1 commit intoopen-telemetry:masterfrom
dynatrace-oss-contrib:feature/settable-format

Conversation

@Oberon00
Copy link
Copy Markdown
Member

Resolves #718.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 24, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.74%. Comparing base (073ece1) to head (863dc35).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #914      +/-   ##
============================================
- Coverage     82.83%   82.74%   -0.09%     
+ Complexity      846      841       -5     
============================================
  Files           113      113              
  Lines          2960     2968       +8     
  Branches        252      252              
============================================
+ Hits           2452     2456       +4     
- Misses          397      399       +2     
- Partials        111      113       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlosalberto
Copy link
Copy Markdown
Contributor

carlosalberto commented Feb 24, 2020

I don't think we want this feature anymore - based on OTEP 66, now the default Propagators will be set by the API, and the user will be able to override them (removing the instances from both Tracer and CorrelationContext).

@Oberon00
Copy link
Copy Markdown
Member Author

Hi @carlosalberto, I know this feature is mostly obsoleted by OTEP 66, but it seems that it will take some time until this is implemented, so I wanted to provide this PR as a remedy in the meantime. I do think, however, that we'd want to have the propagators configurable via the builder even after OTEP 66 has landed in java.

@carlosalberto
Copy link
Copy Markdown
Contributor

So we really need OTEP 66 changes for the beta (March 16th). As mentioned in the related PR, now that I have my hands a little free-r, we should be able to keep that feature ready/merged relatively soon (I hope we get most of the things done/ready this week TBH).

I'd put a "Holding on" on this issue while we work on that one, and decide to apply this if for some reason we can't get it merged in 1-2 weeks.

@bogdandrutu
Copy link
Copy Markdown
Member

@Oberon00 is this obsolete now?

@Oberon00
Copy link
Copy Markdown
Member Author

I'm not sure. How would you set a custom text format with the new API? I'll look it up.

@Oberon00
Copy link
Copy Markdown
Member Author

That is to say, this PR is certainly obsolete now, but I'll need to check if #718 can be closed.

@Oberon00 Oberon00 closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No way to change HttpTextFormat

6 participants