fix: improve type stubs#137
Merged
terraputix merged 21 commits intomainfrom Apr 21, 2026
Merged
Conversation
…-causes-excessive-s3-range-requests-for-partial-reads
…-causes-excessive-s3-range-requests-for-partial-reads
…-causes-excessive-s3-range-requests-for-partial-reads
There was a problem hiding this comment.
Pull request overview
Updates the Rust-exposed Python writer API signatures and documentation to produce more precise generated Python type stubs for OmFileWriter.
Changes:
- Switch several
OmFileWriterPython-exposed parameters fromOptional[...]to non-optional with explicit defaults via#[pyo3(signature=...)]. - Improve/expand docstrings for array/scalar writing, and refine stub types for streaming inputs (
Iterator[NDArray[Any]],numpy.dtype[Any]). - Adjust Rust tests to match the updated method signatures.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/writer.rs |
Updates PyO3 signatures/arg types and expands docs for writer methods; adjusts tests accordingly. |
python/omfiles/_rust/__init__.pyi |
Regenerated/updated type stubs to reflect new signatures and improved typing for streaming APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
terraputix
force-pushed
the
improve-type-stubs
branch
2 times, most recently
from
26a903b to
6b80240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OmFileWriterPython-exposed parameters fromOptional[...]to non-optional with explicit defaults via#[pyo3(signature=...)].Iterator[NDArray[Any]],numpy.dtype[Any]).