RFC - AI Avatar Animation Design#59
Merged
Merged
Conversation
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
4 tasks
ctao456
changed the title
ctao456
changed the title
4 tasks
Signed-off-by: Chun Tao <chun.tao@intel.com>
louie-tsai
reviewed
Aug 6, 2024
Contributor
louie-tsai
left a comment
louie-tsai
left a comment
There was a problem hiding this comment.
Great works. put some comments in PR.
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
ctao456
changed the title
Signed-off-by: Chun Tao <chun.tao@intel.com>
ctao456
requested review from
chensuyue,
chickenrae,
dbkinder,
ftian1,
mkbhanda,
preethivenkatesh and
tomlenth
as code owners
dbkinder
suggested changes
Sep 9, 2024
Contributor
dbkinder
left a comment
dbkinder
left a comment
There was a problem hiding this comment.
Just a title suggested fix
dbkinder
reviewed
Sep 9, 2024
Contributor
dbkinder
left a comment
dbkinder
left a comment
There was a problem hiding this comment.
Looks like you didn't do a "git commit -s" so your PR is missing the required Signed-off-by: line in the commit message :(
Co-authored-by: David Kinder <david.b.kinder@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
* use improved globbing pattern to collect markdown docs in the repos * add GenAIInfra/proxy docs to deploy section (was in opea-project#96) Signed-off-by: David B. Kinder <david.b.kinder@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
Contributor
Author
Thank you. That was true. I was using the web interface to commit. Should never use it. I fixed it by rebasing to HEAD~2 and commited with sign-off, then force pushing. |
tomlenth
pushed a commit
that referenced
this pull request
Sep 17, 2024
* rfc draft Signed-off-by: Chun Tao <chun.tao@intel.com> * rfc pics Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * revert unncecessary changes Signed-off-by: Chun Tao <chun.tao@intel.com> * revert unnecessary changes Signed-off-by: Chun Tao <chun.tao@intel.com> * Update 24-08-02-OPEA-AIAvatarChatbot.md Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * updates to include mjpegs Signed-off-by: Chun Tao <chun.tao@intel.com> * switch to mpg files Signed-off-by: Chun Tao <chun.tao@intel.com> * switched to gif Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * update flowcharts Signed-off-by: Chun Tao <chun.tao@intel.com> * update flowcharts Signed-off-by: Chun Tao <chun.tao@intel.com> * updated mermaid graph with larger font Signed-off-by: Chun Tao <chun.tao@intel.com> * updated flowchart Signed-off-by: Chun Tao <chun.tao@intel.com> * update flowchart Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * update rfc Signed-off-by: Chun Tao <chun.tao@intel.com> * delete avatar 5 Signed-off-by: Chun Tao <chun.tao@intel.com> * Update avatar flowchart Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * Update community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Co-authored-by: David Kinder <david.b.kinder@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com> * doc: improved use of globbing in toctree (#99) * use improved globbing pattern to collect markdown docs in the repos * add GenAIInfra/proxy docs to deploy section (was in #96) Signed-off-by: David B. Kinder <david.b.kinder@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com> --------- Signed-off-by: Chun Tao <chun.tao@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com> Signed-off-by: David B. Kinder <david.b.kinder@intel.com> Co-authored-by: David Kinder <david.b.kinder@intel.com> Signed-off-by: Tom Lenth <tom.f.lenth@intel.com>
ZePan110
reviewed
Sep 25, 2024
Comment on lines
+192
to
+193
| <!-- [AI Avatar Chatbot Demo on Intel® Gaudi® 2, image input](https://intel.sharepoint.com/:v:/s/mlconsultingandsupport/EZa7vjON10ZCpMvE7U-SPMwBRXbVHqe1Ybsa-fmnXayNUA?e=f6FPsl) | ||
| [AI Avatar Chatbot Demo on Intel® Gaudi® 2, video input](https://intel.sharepoint.com/:v:/s/mlconsultingandsupport/ESMIcBseFTdIuqkoB7TZy6ABfwR9CkfV49TvTa1X_Jihkg?e=zMH7O7) --> |
Collaborator
There was a problem hiding this comment.
@ctao456 We shouldn't have such an URL in our documentation (it's not accessible to the community). If that video is important, it should be put in a public location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RFC for AI avatar animation project
opea-project/GenAIComps#400
opea-project/GenAIExamples#523