Skip to content

refactor the network port setting for AWS#849

Merged
chensuyue merged 12 commits into
opea-project:mainfrom
NeoZhangJianyu:jianyuzh_network_port
Sep 19, 2024
Merged

refactor the network port setting for AWS#849
chensuyue merged 12 commits into
opea-project:mainfrom
NeoZhangJianyu:jianyuzh_network_port

Conversation

@NeoZhangJianyu
Copy link
Copy Markdown
Collaborator

Description

refactor the description of network port setting for AWS.

Issues

the description of network port setting is not clear.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Comment thread ChatQnA/docker_compose/intel/cpu/xeon/README.md Outdated
@xiguiw xiguiw force-pushed the jianyuzh_network_port branch from 197031e to 618ff04 Compare September 19, 2024 09:21
@kevinintel
Copy link
Copy Markdown
Contributor

please update readme of gaudi and ChatQnA

@NeoZhangJianyu
Copy link
Copy Markdown
Collaborator Author

please update readme of gaudi and ChatQnA

yes, update them.

Comment thread ChatQnA/README.md Outdated
Comment thread ChatQnA/README.md Outdated
Comment thread ChatQnA/docker_compose/intel/cpu/xeon/README.md Outdated
Comment thread ChatQnA/docker_compose/intel/hpu/gaudi/README.md Outdated
Comment thread ChatQnA/docker_compose/nvidia/gpu/README.md Outdated
Comment thread ChatQnA/docker_compose/intel/cpu/xeon/README.md Outdated
Comment thread ChatQnA/docker_compose/intel/cpu/xeon/README.md Outdated
Copy link
Copy Markdown
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ChatQnA/docker_compose/intel/cpu/xeon/README.md Outdated
@yinghu5 yinghu5 changed the title refacor the network port setting for AWS refactor the network port setting for AWS Sep 19, 2024
Comment thread ChatQnA/docker_compose/intel/cpu/xeon/README.md Outdated
@chensuyue chensuyue merged commit bc81770 into opea-project:main Sep 19, 2024
@mkbhanda
Copy link
Copy Markdown
Collaborator

Thank @NeoZhangJianyu and team!

wangkl2 pushed a commit to wangkl2/GenAIExamples that referenced this pull request Dec 11, 2024
* fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Co-authored-by: ZhangJianyu <zhang.jianyu@outlook.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants