Skip to content

ChatQnA - refactoring README.md for deploy application on ROCm#1857

Merged
joshuayao merged 31 commits into
opea-project:mainfrom
chyundunovDatamonsters:feature/ChatQnA_new_README
Apr 25, 2025
Merged

ChatQnA - refactoring README.md for deploy application on ROCm#1857
joshuayao merged 31 commits into
opea-project:mainfrom
chyundunovDatamonsters:feature/ChatQnA_new_README

Conversation

@chyundunovDatamonsters

@chyundunovDatamonsters chyundunovDatamonsters commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

Description

A refactoring of the README is required, following the template for deploy application on ROCm

Issues

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [*] New feature (non-breaking change which adds new functionality)

Dependencies

Tests

Chingis Yundunov and others added 24 commits February 13, 2025 10:02
DocSum - add files for deploy app with ROCm vLLM
cf60682 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
DocSum - fix main
1fd1de1 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
DocSum - add files for deploy app with ROCm vLLM
bd2d47e 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
DocSum - fix main
2459ecb 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Merge remote-tracking branch 'origin/main'
4d35065
DocSum - add files for deploy app with ROCm vLLM
6d5049d 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
DocSum - fix main
9dfbdc5 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
DocSum - add files for deploy app with ROCm vLLM
a8857ae 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
DocSum - fix main
5a38b26 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Merge remote-tracking branch 'origin/main'
0e2ef94
Merge branch 'main' of https://github.com/opea-project/GenAIExamples
30071db
@artem-astafev
Merge branch 'opea-project:main' into main
0757dec
Merge branch 'main' of https://github.com/opea-project/GenAIExamples
9aaf378
Merge branch 'main' of https://github.com/opea-project/GenAIExamples
9cf4b6e
Merge branch 'main' of https://github.com/opea-project/GenAIExamples
8e89787
Merge branch 'main' of https://github.com/opea-project/GenAIExamples
a117c69
Merge branch 'main' of https://github.com/opea-project/GenAIExamples
7fed5cf
Merge branch 'main' of https://github.com/opea-project/GenAIExamples
28504e1
@chyundunovDatamonsters
Merge branch 'main' of https://github.com/opea-project/GenAIExamples
4cd6a50
@chyundunovDatamonsters
ChatQnA - refactoring README.md
895f801 
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
@chyundunovDatamonsters
ChatQnA - refactoring README.md
6903d8a 
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
@chyundunovDatamonsters
ChatQnA - refactoring README.md
a165159 
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
@chyundunovDatamonsters
ChatQnA - refactoring README.md
a612b4a 
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
@chyundunovDatamonsters
ChatQnA - refactoring README.md
e01589c 
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
@github-actions

github-actions Bot commented Apr 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@joshuayao joshuayao linked an issue Apr 22, 2025 that may be closed by this pull request
[Doc] Refine the README for ChatQnA #1677
Closed
4 tasks
@joshuayao joshuayao mentioned this pull request Apr 21, 2025
Closed
4 tasks
@joshuayao joshuayao added this to OPEA Apr 22, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 22, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 22, 2025
@joshuayao joshuayao added documentation Improvements or additions to documentation v1.3 labels Apr 22, 2025
@yinghu5 yinghu5 requested a review from Copilot April 22, 2025 08:36
Copilot AI reviewed Apr 22, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@chyundunovDatamonsters
ChatQnA - refactoring README.md
39bb7ae 
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
@chyundunovDatamonsters
Merge remote-tracking branch 'origin/feature/ChatQnA_new_README' into…
b410360 
… feature/ChatQnA_new_README
lvliang-intel
lvliang-intel reviewed Apr 23, 2025
View reviewed changes
Comment thread ChatQnA/docker_compose/amd/gpu/rocm/README.md Outdated
Comment thread ChatQnA/docker_compose/amd/gpu/rocm/README.md Outdated
@joshuayao

joshuayao commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator

Hi @chyundunovDatamonsters could you please check the review comments? Thanks.

letonghan
letonghan reviewed Apr 24, 2025
View reviewed changes
Comment thread ChatQnA/docker_compose/amd/gpu/rocm/README.md Outdated
@joshuayao joshuayao self-requested a review April 25, 2025 00:52
@joshuayao joshuayao merged commit bb7a675 into opea-project:main Apr 25, 2025
@github-project-automation github-project-automation Bot moved this from In review to Done in OPEA Apr 25, 2025
chensuyue pushed a commit that referenced this pull request Apr 25, 2025
@chyundunovDatamonsters @artem-astafev
@pre-commit-ci @chensuyue
ChatQnA - refactoring README.md for deploy application on ROCm (#1857)
d1a8f0d 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Co-authored-by: Chingis Yundunov <YundunovCN@sibedge.com>
Co-authored-by: Artem Astafev <a.astafev@datamonsters.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit bb7a675)
yongfengdu pushed a commit to yongfengdu/GenAIExamples that referenced this pull request May 8, 2025
@chyundunovDatamonsters @artem-astafev
@pre-commit-ci @yongfengdu
ChatQnA - refactoring README.md for deploy application on ROCm (opea-…
c65c490 
…project#1857)

Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Co-authored-by: Chingis Yundunov <YundunovCN@sibedge.com>
Co-authored-by: Artem Astafev <a.astafev@datamonsters.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
chyundunovDatamonsters added a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
@chyundunovDatamonsters @artem-astafev @pre-commit-ci
ChatQnA - refactoring README.md for deploy application on ROCm (opea-…
b068668 
…project#1857)

Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Co-authored-by: Chingis Yundunov <YundunovCN@sibedge.com>
Co-authored-by: Artem Astafev <a.astafev@datamonsters.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
letonghan pushed a commit that referenced this pull request Sep 17, 2025
@lvliang-intel
Use sglang main branch for sglang docker (#1857)
a1b9a6c 
* Use sglang main branch for sglang docker

Signed-off-by: lvliang-intel <liang1.lv@intel.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
@chyundunovDatamonsters @artem-astafev
@pre-commit-ci @cogniware-devops
ChatQnA - refactoring README.md for deploy application on ROCm (opea-…
054840f 
…project#1857)

Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Co-authored-by: Chingis Yundunov <YundunovCN@sibedge.com>
Co-authored-by: Artem Astafev <a.astafev@datamonsters.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@letonghan letonghan letonghan left review comments

Copilot code review Copilot Copilot left review comments

@joshuayao joshuayao joshuayao approved these changes

@lvliang-intel lvliang-intel lvliang-intel approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation v1.3

Projects

OPEA
Status: Done

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

[Doc] Refine the README for ChatQnA

6 participants

@chyundunovDatamonsters @joshuayao @lvliang-intel @letonghan @artem-astafev