[Pending] Merge Translation and CodeTrans examples#1670
Conversation
…compose of rocm and xeon part Signed-off-by: letonghan <letong.han@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
for more information, see https://pre-commit.ci
…into merge_translation
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
lianhao
left a comment
lianhao
left a comment
There was a problem hiding this comment.
Do we still have codetrans e2e example after this merge? Or the codetrans e2e will be gone?
|
|
||
| ``` | ||
| export HFTOKEN="insert-your-huggingface-token-here" | ||
| helm install codetrans oci://ghcr.io/opea-project/charts/codetrans --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} -f gaudi-values.yaml |
There was a problem hiding this comment.
This only works with codetrans, won't work with translation. We need to create a new helm chart for translation after this PR is merged. I would suggest keep the helm chart part empty here.
There was a problem hiding this comment.
Sounds like we should leave this part empty, and the helm chart of these two examples should be merged into one
The CodeTrans example will be removed, and only the Translation example exists in GenAIExample. |
joshuayao
left a comment
joshuayao
left a comment
There was a problem hiding this comment.
Let's hold off on merging this PR to v1.3 for now.
letonghan
changed the title
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
5 participants
Description
Refactor Translation example and merge with CodeTrans.
Update python files, READMEs, docker compose files and k8s files.
The endpoint of megaservice is unified to
/v1/translation, and add an additional parametertranslation_typefor different llm prompt.Issues
#1240
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Describe the tests that you ran to verify your changes.