Skip to content

Fix missing end of file chars#1106

Merged
ashahba merged 6 commits into
opea-project:mainfrom
ashahba:ashahba/end-of-file-fix
Nov 13, 2024
Merged

Fix missing end of file chars#1106
ashahba merged 6 commits into
opea-project:mainfrom
ashahba:ashahba/end-of-file-fix

Conversation

@ashahba
Copy link
Copy Markdown
Collaborator

@ashahba ashahba commented Nov 8, 2024

Description

This PR fixes missing end of file chars across the repo.
This is the command I used to fix them all in one shot:

git ls-files -z | while IFS= read -rd '' f; do if file --mime-encoding "$f" | grep -qv binary; then tail -c1 < "$f" | read -r _ || echo >> "$f"; fi; done

Issues

Currently the check for missing end of file's is failing the linter tests but we have many files across the repo with that same issue which needs fix anyway.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.: None

Tests

Describe the tests that you ran to verify your changes.
Lint tests should pass without any issues since the files in the PR was touched.

Signed-off-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com>
@ashahba ashahba added this to the v1.1 milestone Nov 8, 2024
@ashahba ashahba added the r1.1 label Nov 8, 2024
@Spycsh
Copy link
Copy Markdown
Collaborator

Spycsh commented Nov 11, 2024

Just curious whether we can have any automatic pre-CI to fix the missing eof for future commits

@ashahba ashahba merged commit b5f95f7 into opea-project:main Nov 13, 2024
@ashahba ashahba deleted the ashahba/end-of-file-fix branch November 13, 2024 17:40
lkk12014402 pushed a commit that referenced this pull request Jan 17, 2025
* Refine component interface

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* update env

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* add health check

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* update mulimodal embedding

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* update import

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* refine other components

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix dataprepissue

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* fix tts issue

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* fix ci issues

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix tts response issue

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix comments

Signed-off-by: lvliang-intel <liang1.lv@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants