fix: ensure window closes even if cleanup fails#596
Merged
Conversation
Owner
|
Thanks for your fix, I have merged it into the master branch. Previously, even if an error occurred during the execution of these functions, pressing the close button again should have forced the app to close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation for closing the application relied on a single promise from
executeJavaScriptwithout a fallback handler. If the cleanup operations failed, thethen()block was not guaranteed to execute, leading to the application becoming unresponsive and unable to close. This change adds acatch()block to ensure the window closes regardless of whether the cleanup operations complete successfully or fail. Closes #1