Skip to content

fix: ensure window closes even if cleanup fails#596

Merged
ollm merged 1 commit into
ollm:masterfrom
MatrixNeoKozak:fix/improvement-1781346140572
Jun 13, 2026
Merged

fix: ensure window closes even if cleanup fails#596
ollm merged 1 commit into
ollm:masterfrom
MatrixNeoKozak:fix/improvement-1781346140572

Conversation

@MatrixNeoKozak

Copy link
Copy Markdown
Contributor

The previous implementation for closing the application relied on a single promise from executeJavaScript without a fallback handler. If the cleanup operations failed, the then() block was not guaranteed to execute, leading to the application becoming unresponsive and unable to close. This change adds a catch() block to ensure the window closes regardless of whether the cleanup operations complete successfully or fail. Closes #1

@ollm

ollm commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Thanks for your fix, I have merged it into the master branch.

Previously, even if an error occurred during the execution of these functions, pressing the close button again should have forced the app to close.

@ollm ollm merged commit 83d801a into ollm:master Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't seem to open .cbr files on Linux

2 participants