Support MiniMax tool call format

[pwilkin]

Minimax has a different format for tools, so need this one more case.

[ochafik]

Thanks @pwilkin ! Could you also update scripts/fetch_templates_and_goldens.py accordingly and run scripts/test.sh locally to check it's all green?

[pwilkin]

Will do.

[pwilkin]

Hm, getting:

The following tests FAILED:
3 - test-polyfills (Failed)
4 - test-capabilities (Failed)
205 - test-supported-template-unsloth-MiniMax-M2-simple (Failed)
307 - test-supported-template-unsloth-MiniMax-M2-system (Failed)
396 - test-supported-template-unsloth-MiniMax-M2-tool_use (Failed)
567 - test-supported-template-zai-org-GLM-4.6-simple (Failed)
568 - test-supported-template-zai-org-GLM-4.6-system (Failed)
569 - test-supported-template-zai-org-GLM-4.6-tool_use (Failed)

[pwilkin]

I managed to get the GLM-4.6 cases working (minor bug) but not the Minimax ones, interesting :/ it seems to be unable to process tool calls.

[ochafik]

Fixed w/ a lil refactor, thanks again!

[ochafik]

There's still an issue w/ the supports_tool_responses capability detection, looking at it.

[ochafik]

So: unfortunately there's a bug in MinMax-M2's template: at line 132:

{%- set last_tool_call.name = message.tool_calls[-1].name -%}

should be:

{%- set last_tool_call.name = message.tool_calls[-1].function.name -%}

see full template

{# Unsloth template fixes #}
{# ----------‑‑‑ special token variables ‑‑‑---------- #}
{%- set toolcall_begin_token   = '<minimax:tool_call>'         -%}
{%- set toolcall_end_token     = '</minimax:tool_call>'        -%}
{#- Tool Rendering Functions ============================================== -#}
{%- macro render_tool_namespace(namespace_name, tool_list) -%}
{%- for tool in tool_list -%}
<tool>{{ tool.function | tojson | string }}</tool>
{% endfor -%}
{%- endmacro -%}
{%- macro visible_text(content) -%}
    {%- if content is string -%}
        {{ content }}
    {%- elif content is iterable and content is not mapping -%}
        {%- for item in content -%}
            {%- if item is mapping and item.type == 'text' -%}
                {{- item.text }}
            {%- elif item is string -%}
                {{- item }}
            {%- endif -%}
        {%- endfor -%}
    {%- else -%}
        {{- content }}
    {%- endif -%}
{%- endmacro -%}
{#- System Message Construction ============================================ -#}
{%- macro build_system_message(system_message) -%}
    {%- if system_message and system_message.content -%}
        {{- visible_text(system_message.content) }}
    {%- else -%}
        {%- if model_identity is not defined -%}
            {%- set model_identity = "You are a helpful assistant." -%}
        {%- endif -%}
        {{- model_identity }}
    {%- endif -%}
    
    {#- Handle current_date -#}
    {%- if system_message and system_message.current_date -%}
        {{- '\n' ~ 'Current date: ' + system_message.current_date }}
    {%- endif -%}
    {#- Handle current_location -#}
    {%- if system_message and system_message.current_location -%}
        {{- '\n' ~ 'Current location: ' + system_message.current_location }}
    {%- endif -%}
{%- endmacro -%}
{#- Main Template Logic ================================================= -#}
{#- Extract system message (only first message if it's system) -#}
{%- set system_message = none -%}
{%- set conversation_messages = messages -%}
{%- if messages and messages[0].role == "system" -%}
    {%- set system_message = messages[0] -%}
    {%- set conversation_messages = messages[1:] -%}
{%- endif -%}
{#- Get the last user message turn, for interleved thinking -#}
{%- set ns = namespace(last_user_index=-1) %}
{% for m in conversation_messages %}
    {%- if m.role == 'user' %}
        {% set ns.last_user_index = loop.index0 -%}
    {%- endif %}
{%- endfor %}
{#- Render system message -#}
{{- ']~!b[' ~ ']~b]system' ~ '\n' }}
{{- build_system_message(system_message) }}
{#- Render tools if available -#}
{%- if tools -%}
    {{- '\n\n' ~ '# Tools' ~ '\n' ~ 'You may call one or more tools to assist with the user query.\nHere are the tools available in JSONSchema format:' ~ '\n' }}
    {{- '\n' ~ '<tools>' ~ '\n' }}
    {{- render_tool_namespace("functions", tools) }}
    {{- '</tools>' ~ '\n\n' }}
{{- 'When making tool calls, use XML format to invoke tools and pass parameters:' ~ '\n' }}
{{- '\n' ~ toolcall_begin_token }}
<invoke name="tool-name-1">
<parameter name="param-key-1">param-value-1</parameter>
<parameter name="param-key-2">param-value-2</parameter>
...
</invoke>
{{- '\n' ~ toolcall_end_token }}
{%- endif -%}
{{- '[e~[\n' }}

{#- Render messages -#}
{%- set last_tool_call = namespace(name=none) -%}
{%- for message in conversation_messages -%}
    {%- if message.role == 'assistant' -%}
        {#- Only render reasoning_content if no user message follows -#}
        {{- ']~b]ai' ~ '\n' }}

        {%- set reasoning_content = '' %}
        {%- set content = visible_text(message.content) %}
        {%- if message.reasoning_content is string %}
            {%- set reasoning_content = message.reasoning_content %}
        {%- else %}
            {%- if '</think>' in content %}
                {# Unsloth template fixes - must change to for loop since llama.cpp will error out if not #}
                {%- set parts = content.split('</think>') %}
                {%- for part in parts %}
                    {%- if loop.index0 == 0 -%}
                        {%- set reasoning_content = part.strip('\n') %}
                        {%- set reasoning_content = (reasoning_content.split('<think>')|last) %}
                        {%- set reasoning_content = reasoning_content.strip('\n') -%}
                    {%- else -%}
                        {%- set content = part.strip('\n') %}
                    {%- endif %}
                {%- endfor %}
            {%- endif %}
        {%- endif %}
        {%- if reasoning_content and loop.index0 > ns.last_user_index -%}
            {{- '<think>' ~ '\n' ~ reasoning_content ~ '\n' ~ '</think>' ~ '\n\n' }}
        {%- endif -%}
        {%- if content -%}
            {{- content }}
        {%- endif -%}
        {%- if message.tool_calls -%}
            {{- '\n' ~ toolcall_begin_token ~ '\n' }}

            {%- for tool_call in message.tool_calls -%}
                {%- if tool_call.function %}
                    {%- set tool_call = tool_call.function %}
                {%- endif %}
                {{- '<invoke name="' + tool_call.name + '">\n' }}
                {%- if tool_call.arguments is defined and tool_call.arguments is mapping -%}
                {% set _args = tool_call.arguments %}
                {%- for k, v in _args|items %}
                {{- '<parameter name="' + k + '">' }}
                {{- v | tojson | string if v is not string else v }}
                {{- '</parameter>' }}
                {% endfor %}{%- endif -%}
                {{- '</invoke>' ~ '\n' }}
            {%- endfor -%}
            
            {{- toolcall_end_token}}
            {%- set last_tool_call.name = message.tool_calls[-1].name -%}
        {%- else -%}
            {%- set last_tool_call.name = none -%}
        {%- endif -%}
        {{- '[e~[' ~ '\n' }}
        
    {%- elif message.role == 'tool' -%}
    {%- if last_tool_call.name is none -%}
        {{- raise_exception("Message has tool role, but there was no previous assistant message with a tool call!") }}
    {%- endif -%}
    {%- if loop.first or (conversation_messages[loop.index0 - 1].role != 'tool') -%}
        {{- ']~b]tool' }}
    {%- endif -%}
    {%- if message.content is string -%}
        {{- '\n<response>' }}
        {{- message.content }}
        {{- '</response>' }}
    {%- else -%}
        {%- for tr in message.content -%}
            {{- '\n<response>' }}
            {{- tr.output if tr.output is defined else (tr.text if tr.type == 'text' and tr.text is defined else tr) }}
            {{- '\n</response>' }}
        {%- endfor -%}
    {%- endif -%}
    {%- if loop.last or (conversation_messages[loop.index0 + 1].role != 'tool') -%}
        {{- '[e~[\n' -}}
    {%- endif -%}
        
    {%- elif message.role == 'user' -%}
        {{- ']~b]user' ~ '\n' }}
        {{- visible_text(message.content) }}
        {{- '[e~[' ~ '\n' }}
    {%- endif -%}
{%- endfor -%}

{#- Generation prompt -#}
{%- if add_generation_prompt -%}
{{- ']~b]ai' ~ '\n' ~ '<think>' ~ '\n' }}
{%- endif -%}
{# Copyright 2025-present Unsloth. Apache 2.0 License. #}

Would you be able to report this bug to them? Until they update their template (and the GGUFs are re-exported), we'll need to provide an alternative template in llama.cpp (cf. templates w/ llama-cpp- prefix here), and we'll have to keep the model id commented out in the minja test cmake list.

[danielhanchen]

@ochafik I can fix it on our end - Is ensure_ascii also supported as well now? By the way nice work on GLM 4.6 as well! Oh I see https://github.com/google/minja/pull/87/files! Nice work!

[ochafik]

@ochafik I can fix it on our end - Is ensure_ascii also supported as well now?

@danielhanchen Supported-ish: the output is always ascii atm, which isn't ideal but at least doesn't explode anymore. Might look into letting unicode chars through when ensure_ascii = False (contribs welcome).

By the way nice work on GLM 4.6 as well!

Thanks!

[danielhanchen]

@ochafik I'm updating MiniMax currently (should be up in a few hours) to include your suggested fix as per @pwilkin's PR as well!

[hksdpc255]

@ochafik Should line 110 in official template {% set _args = tool_call.arguments %} be guarded by an additional conditional check like {%- if tool_call.arguments is defined and tool_call.arguments is mapping -%}?
I'm not sure whether this issue comes from the template itself or from Minja’s behavior.

[danielhanchen]

@hksdpc255 Yes there should be a guard! I had one on our version: https://huggingface.co/unsloth/MiniMax-M2/blob/main/chat_template.jinja

@pwilkin @ochafik I've updated https://huggingface.co/unsloth/MiniMax-M2-GGUF - all will be updated with the suggested fixes!

[CISC]

@ochafik I can fix it on our end - Is ensure_ascii also supported as well now?

@danielhanchen Supported-ish: the output is always ascii atm, which isn't ideal but at least doesn't explode anymore. Might look into letting unicode chars through when ensure_ascii = False (contribs welcome).

Unicode is default when using tojson, I have no idea why they insist on using ensure_ascii=False, you should only output ascii when ensure_ascii=True.

[ochafik]

@ochafik Should line 110 in official template {% set _args = tool_call.arguments %} be guarded by an additional conditional check like {%- if tool_call.arguments is defined and tool_call.arguments is mapping -%}?

@hksdpc255 Yes there should be a guard!

@hksdpc255 @danielhanchen Can you file a bug w/ what happens there? We should always aim to fix minja rather that work around it in templates :-)

[hksdpc255]

@ochafik I’m not sure whether this is a bug in Minja or in the chat template. But let me do a quick test if the issue still exists.

[hksdpc255]

The issue seems to have magically disappeared with the latest code.

Can you confirm if it also works for you without the extra check for tool_call.arguments? @danielhanchen