support rsplit#24
Conversation
|
@ochafik please check again |
ochafik
left a comment
ochafik
left a comment
There was a problem hiding this comment.
Hi @f291400 , thanks for opening this PR
The tests seem to cover something different than rsplit. Can you drop those changes and add a test for rsplit in test-syntax, and also mention in which template you've seen this? (if this unlock a new template, can you add it to the tested model ids in tests/CMakeLists.txt ?)
As for the thinking tests, I'm preparing an overhaul of thinking patterns in templates and their testing, stay tuned!
|
@ochafik Currently, none of the open-source large language models use |
|
Could you kindly review the current submission? |
|
@ochafik gentle ping |
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
|
@ochafik Oh hey, where have you been? :) |
3 participants
No description provided.