MAIN: Update c,c++ line length to 88#28339
Merged
mattip merged 1 commit intonumpy:mainfrom Feb 18, 2025
Merged
Conversation
This makes the c/c++ line length the same as the modern Python defaults. Note that linux has dropped the hard 80 character limit, it is now only preferred. I don't know how to configure a linter for "preferred", so just make the hard limit 88.
Member
|
Do we want to run this on the repository to reformat the existing code base? |
Member
|
I think reformatting all the code would create too much noise for the benefit gained. But if there are particular areas of the code that could be helped, we should reformat them selectively. |
Member
|
Thanks @charris |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the c/c++ line length the same as the modern Python defaults. Note that linux has dropped the hard 80 character limit, it is now only preferred. I don't know how to configure a linter for "preferred", so just make the hard limit 88.