Skip to content

Add test coverage for millisecond support in timeToSeconds#39

Draft
andmoredev with Copilot wants to merge 3 commits into
try-to-fix-some-stufffrom
copilot/sub-pr-37-again
Draft

Add test coverage for millisecond support in timeToSeconds#39
andmoredev with Copilot wants to merge 3 commits into
try-to-fix-some-stufffrom
copilot/sub-pr-37-again

Conversation

Copilot AI commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

The timeToSeconds function was enhanced to parse milliseconds (format: HH:MM:SS,mmm and MM:SS,mmm), but the test suite only validated the base HH:MM:SS and MM:SS formats.

Changes:

  • Updated test implementation to match actual function signature with comma-separated millisecond parsing
  • Added test cases for HH:MM:SS,mmm format: '00:00:00,000', '01:30:45,500', '00:00:01,100', '02:15:30,250'
  • Added test cases for MM:SS,mmm format: '00:00,000', '10:00,100', '01:30,500', '05:45,750'
  • Fixed parseInt(msPart)parseInt(msPart, 10) in both source and test to use explicit radix

Example:

timeToSeconds('01:30:45,500')  // 5445.5 seconds
timeToSeconds('10:00,100')     // 600.1 seconds

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 18, 2026 19:56
Co-authored-by: andmoredev <33256364+andmoredev@users.noreply.github.com>
Co-authored-by: andmoredev <33256364+andmoredev@users.noreply.github.com>
Copilot AI changed the title [WIP] Update to address feedback on 'apply claude code fixes' PR Add test coverage for millisecond support in timeToSeconds Feb 18, 2026
Copilot AI requested a review from andmoredev February 18, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants