Skip to content

try and fix infinite loop for clips loading #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andmoredev merged 1 commit into from
Feb 13, 2026
Merged

try and fix infinite loop for clips loading #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/pages/EpisodeClipsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ function EpisodeClipsPage() {
}
}

const handleClipsLoaded = (counts: { total: number; proposed: number; processing: number; processed: number }, allClips: ClipListView[]) => {
const handleClipsLoaded = useCallback((counts: { total: number; proposed: number; processing: number; processed: number }, allClips: ClipListView[]) => {
setClipCounts(counts)
setClips(allClips)
}
}, [])

Copilot AI Feb 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useCallback has an empty dependency array, but the callback uses setClipCounts and setClips. If these setters are not stable (e.g., not from useState), or if there are any external dependencies that should trigger a new callback reference, the empty array could cause stale closures. Verify that setClipCounts and setClips are stable setter functions from useState or include them in the dependency array if needed.

Suggested change
}, [])
}, [setClipCounts, setClips])

Copilot uses AI. Check for mistakes.

if (loading) {
return <LoadingSpinner variant="page" />
Expand Down
Loading