chore: use smooth path utility from vue-data-ui#2647
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
No user-facing changes in this release. WalkthroughThe Changes
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shuuji3
left a comment
There was a problem hiding this comment.
LGTM 👍🏻
I put one suggestion for small refactoring.
| import { joinURL } from 'ufo' | ||
| import { smoothPath, useCharts } from '~/composables/useCharts' | ||
| import { useCharts } from '~/composables/useCharts' | ||
| import { createSmoothPath as smoothPath } from 'vue-data-ui/utils' |
There was a problem hiding this comment.
| import { createSmoothPath as smoothPath } from 'vue-data-ui/utils' | |
| import { createSmoothPath } from 'vue-data-ui/utils' |
nit: It seems that the usage of this fuction is only here in the project (https://github.com/npmx-dev/npmx.dev/pull/2647/changes#diff-989803a8350f5b506a5bdea17a1237c410d7eee66b2e7015b0bd46378a78e097R243)
Maybe we could refactor to use the original exported name?
There was a problem hiding this comment.
@shuuji3 thank you :) It is cleaner indeed
Follow up to #2292
This replaces the smooth path creation function used for og images with the available utility in vue-data-ui.