docs: use git+https in package.com url examples#7615
Merged
wraithgar merged 1 commit intonpm:latestfrom Jun 27, 2024
Merged
Conversation
2 tasks
wraithgar
approved these changes
Jun 27, 2024
Merged
2 tasks
Contributor
Author
|
Unfortunately there is a typo in the title of this PR and in the commit message. It should say: "docs: use git+https in package.json url examples" not "package.com"
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpsandgit+https#7614Issue
Examples in the repository section of the npm CI > Configuring npm > package.json reference page use the protocol
https. The examples are:Executing
npm pkg fixin a repo with aurldefinition andprotocolusinghttpsnormalizes the protocol togit+https.Examples should be aligned with what
npm pkg fixconsiders correct and should also be aligned to the list of valid protocols in the Git URLs as Dependencies section, which states:Change
npm/cli.gitChange to
facebook/react.gitSince the source example of https://github.com/facebook/react/blob/main/packages/react-dom/package.json does not use the correct
git+httpsprotocol, use instead