Use `proc-log` for stdout and stderr by lukekarrys · Pull Request #7373 · npm/cli

lukekarrys · 2024-04-12T23:14:25Z

deps: @npmcli/git@5.0.6
deps: @npmcli/package-json@5.0.3
deps: npm-package-arg@11.0.2
deps: npm-profile@9.0.1
deps: npm-registry-fetch@16.2.1
deps: pacote@17.0.7
deps: proc-log@4.0.0
deps: @npmcli/run-script@8.0.0
feat(libnpmversion)!: remove silent option
feat(libnpmpack)!: remove silent option
feat(libnpmexec)!: no longer accept output function
feat: do all ouput over proc-log events

TODO

Release pacote@18 deps: bump @npmcli/run-script from 7.0.4 to 8.0.0 pacote#352
Replace git dep in this PR with published pacote
~~If feat: add time and input proc-log#80 lands we can make the read() related breaking changes here (or in a following PR before the next release) to minimize major versions of libnpmexec.~~ For a later PR

lib/commands/unpublish.js

lib/utils/display.js

wraithgar · 2024-04-16T03:25:21Z

~~TODO: make sure we understand why signal-exit is not in node_modules anymore. I am pretty sure it's a dependency of write-file-atomic.~~

test/lib/npm.js

wraithgar · 2024-04-16T03:43:42Z

The breaking change commits for libnpmversion and libnpmpack need BREAKING CHANGE clauses.

lukekarrys · 2024-04-16T04:10:19Z

I'm not sure what combination of install commands caused signal-exit to update, but in doing so it looks like it deleted two erroneous files that are currently present in node_modules/signal-exit but shouldn't be: https://github.com/npm/cli/tree/9622597399ec93224fddf90a9209a98dbcfd6b2f/node_modules/signal-exit

wraithgar · 2024-04-16T06:21:14Z

LGTM. update the comment, rebase/squash, and I'll approve it. Thanks for taking it in steps w/ TODOS.

BREAKING CHANGE: libnpmexec now emits an output event on process instead of invoking the output function passed in

BREAKING CHANGE: libnpmversion no longer takes a `silent` option to suppress output from `@npmcli/run-script`. That output is now emitted via an `output` event on `process`.

BREAKING CHANGE: libnpmpack no longer takes a `silent` option to suppress output from `@npmcli/run-script`. That output is now emitted via an `output` event on `process`.

lukekarrys · 2024-04-16T15:18:22Z

@wraithgar I added BREAKING CHANGE notes, updated the comments, and rebased so commit linting should pass now.

lukekarrys added 5 commits April 12, 2024 15:22

deps: @npmcli/git@5.0.6

1cb9688

deps: @npmcli/package-json@5.0.3

97fb591

deps: npm-package-arg@11.0.2

9dd15ad

deps: npm-profile@9.0.1

1320fc5

deps: npm-registry-fetch@16.2.1

5567670

lukekarrys changed the title ~~lk/proc log deps~~ Update proc-log and @npmcli/run-script deps Apr 12, 2024

lukekarrys force-pushed the lk/proc-log-deps branch 9 times, most recently from 09526ae to 0b77f20 Compare April 13, 2024 01:44

lukekarrys changed the title ~~Update proc-log and @npmcli/run-script deps~~ Use proc-log out stdout and stderr Apr 13, 2024

lukekarrys force-pushed the lk/proc-log-deps branch from 0b77f20 to f2e0073 Compare April 13, 2024 23:47

lukekarrys changed the title ~~Use proc-log out stdout and stderr~~ Use proc-log for stdout and stderr Apr 14, 2024

wraithgar mentioned this pull request Apr 15, 2024

[epic] npm logging, output, and cleaning npm/statusboard#810

Closed

wraithgar reviewed Apr 15, 2024

View reviewed changes

lib/commands/unpublish.js Outdated Show resolved Hide resolved

deps: pacote@18.0.0

d853ab9

lukekarrys force-pushed the lk/proc-log-deps branch from 61ea31c to dedb25e Compare April 15, 2024 22:25

lukekarrys marked this pull request as ready for review April 15, 2024 22:34

lukekarrys requested a review from a team as a code owner April 15, 2024 22:34

lukekarrys added 2 commits April 15, 2024 15:37

deps: proc-log@4.0.0

25c5621

deps: @npmcli/run-script@8.0.0

f36f873

lukekarrys force-pushed the lk/proc-log-deps branch 2 times, most recently from e612ae9 to d9985cc Compare April 15, 2024 23:43

lukekarrys mentioned this pull request Apr 16, 2024

Emit timers via proc-log #7378

Merged

1 task