[BUG] ERESOLVE overriding peer dependency in 11.2.0 and newer

[Artur-]

Is there an existing issue for this?

• I have searched the existing issues

This issue exists in the latest npm version

• I am using the latest npm

Current Behavior

Given package.json

{
  "name": "no-name",
  "license": "UNLICENSED",
  "type": "module",
  "dependencies": {
    "@vaadin/react-components": "24.9.2",
    "@vaadin/react-components-pro": "24.9.2"
  },
  "overrides": {
    "@vaadin/react-components": "$@vaadin/react-components",
    "@vaadin/react-components-pro": "$@vaadin/react-components-pro"
  }
}

Running npx -y npm@11.2 install results in

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @vaadin/react-components-pro@24.9.2
npm warn Found: @types/react@19.2.2
npm warn node_modules/@types/react
npm warn   peer @types/react@"17 || 18 || 19" from @lit/react@1.0.8
npm warn   node_modules/@lit/react
npm warn     @lit/react@"^1.0.7" from @vaadin/react-components@24.9.2
npm warn     node_modules/@vaadin/react-components
npm warn   1 more (@vaadin/react-components)
npm warn
npm warn Could not resolve dependency:
npm warn peerOptional @types/react@"^18.2.37 || ^19" from @vaadin/react-components-pro@24.9.2
npm warn node_modules/@vaadin/react-components-pro
npm warn   @vaadin/react-components-pro@"24.9.2" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @vaadin/react-components-pro@24.9.2
npm warn Found: react-dom@19.2.0
npm warn node_modules/react-dom
npm warn   peer react-dom@"^18.2.0 || ^19" from @vaadin/react-components@24.9.2
npm warn   node_modules/@vaadin/react-components
npm warn     @vaadin/react-components@"24.9.2" from the root project
npm warn     1 more (@vaadin/react-components-pro)
npm warn
npm warn Could not resolve dependency:
npm warn peer react-dom@"^18.2.0 || ^19" from @vaadin/react-components-pro@24.9.2
npm warn node_modules/@vaadin/react-components-pro
npm warn   @vaadin/react-components-pro@"24.9.2" from the root project

and npx -y npm@11.2 ls --all

npm error code ELSPROBLEMS
npm error invalid: @lit/react@1.0.8 /Users/artur/test/npm-error/node_modules/@lit/react
npm error invalid: @types/react@19.2.2 /Users/artur/test/npm-error/node_modules/@types/react
npm error invalid: react-dom@19.2.0 /Users/artur/test/npm-error/node_modules/react-dom
npm error invalid: @vaadin/a11y-base@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/a11y-base
npm error invalid: @vaadin/button@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/button
npm error invalid: @vaadin/checkbox@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/checkbox
npm error invalid: @vaadin/component-base@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/component-base
npm error invalid: @vaadin/confirm-dialog@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/confirm-dialog
npm error invalid: @vaadin/dialog@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/dialog
npm error invalid: @vaadin/form-layout@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/form-layout
npm error invalid: @vaadin/grid@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/grid
npm error invalid: @vaadin/lit-renderer@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/lit-renderer
npm error invalid: @vaadin/overlay@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/overlay
npm error invalid: @vaadin/select@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/select
npm error invalid: @vaadin/text-field@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/text-field
npm error invalid: @vaadin/tooltip@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/tooltip
npm error invalid: @vaadin/vaadin-lumo-styles@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/vaadin-lumo-styles
npm error invalid: @vaadin/vaadin-material-styles@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/vaadin-material-styles
npm error invalid: @vaadin/vaadin-themable-mixin@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/vaadin-themable-mixin
npm error invalid: @polymer/polymer@3.5.2 /Users/artur/test/npm-error/node_modules/@polymer/polymer
npm error invalid: lit@3.3.1 /Users/artur/test/npm-error/node_modules/lit
npm error invalid: @vaadin/field-base@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/field-base
npm error invalid: @vaadin/input-container@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/input-container
npm error invalid: @vaadin/item@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/item
npm error invalid: @vaadin/list-box@24.9.2 /Users/artur/test/npm-error/node_modules/@vaadin/list-box

Expected Behavior

npx -y npm@11.1 install

results in no errors

npx -y npm@11.1 ls --all

results in no errors

Steps To Reproduce

As above

Environment

• npm: 11.2+, including the not yet released 11.6.3
• Node.js: 24.9.0
• OS Name: mac os

[Artur-]

Bisect revels it was introduced in #8089

[nikunj-kohli]

I would like to contribute here, I request you to assign me

[Artur-]

@nikunj-kohli There is a pr in #8689 that you can review and comment on