test: skip non-applicable unit tests on Windows#651
Merged
priteshbandi merged 2 commits intonotaryproject:mainfrom Apr 27, 2023
Merged
test: skip non-applicable unit tests on Windows#651priteshbandi merged 2 commits intonotaryproject:mainfrom
priteshbandi merged 2 commits intonotaryproject:mainfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 33.16% 33.16%
=======================================
Files 32 32
Lines 2014 2014
=======================================
Hits 668 668
Misses 1324 1324
Partials 22 22 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
4077014 to
7340c34
Compare
shizhMSFT
reviewed
Apr 26, 2023
Contributor
shizhMSFT
left a comment
There was a problem hiding this comment.
The PR title should be test: skip non-applicable unit tests on Windows.
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
6 tasks
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
skip some unit test cases because Windows handles file permissions differently from Unix-based systems, and therefore, using file permissions like 0000, 0600, 0644, or 0700 in tests may not work as expected on Windows. Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
skip some unit test cases because Windows handles file permissions differently from Unix-based systems, and therefore, using file permissions like 0000, 0600, 0644, or 0700 in tests may not work as expected on Windows. Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unit test:
Test:
Test output:
Signed-off-by: Junjie Gao junjiegao@microsoft.com