Skip to content

chore: update the examples of sign and verify#650

Merged
priteshbandi merged 8 commits intonotaryproject:mainfrom
patrickzheng200:fix
Apr 27, 2023
Merged

chore: update the examples of sign and verify#650
priteshbandi merged 8 commits intonotaryproject:mainfrom
patrickzheng200:fix

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 commented Apr 26, 2023

This PR updates long messages of sign and verify.
When NOTATION_EXPERIMENTAL variable is not set, experimental examples will be hidden.

Resolves #645.

Patrick Zheng added 3 commits April 25, 2023 17:14
fix
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 26, 2023

Codecov Report

Merging #650 (bd8a949) into main (2e56dd4) will increase coverage by 0.16%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   33.16%   33.33%   +0.16%     
==========================================
  Files          32       32              
  Lines        2014     2019       +5     
==========================================
+ Hits          668      673       +5     
  Misses       1324     1324              
  Partials       22       22              
Impacted Files Coverage Δ
cmd/notation/list.go 28.94% <100.00%> (ø)
cmd/notation/sign.go 43.06% <100.00%> (+1.27%) ⬆️
cmd/notation/verify.go 32.30% <100.00%> (+1.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Patrick Zheng added 2 commits April 27, 2023 11:12
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 4589c83 into notaryproject:main Apr 27, 2023
@patrickzheng200 patrickzheng200 deleted the fix branch April 28, 2023 07:53
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
When NOTATION_EXPERIMENTAL variable is not set, experimental examples will be hidden. Resolves notaryproject#645.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
When NOTATION_EXPERIMENTAL variable is not set, experimental examples will be hidden. Resolves notaryproject#645.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Need to triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Examples were shown for experimental feature

4 participants