Skip to content

feat: use Referrers API per OCI v1.1 spec #602

Merged
patrickzheng200 merged 1 commit intonotaryproject:mainfrom
patrickzheng200:referrers
Mar 29, 2023
Merged

feat: use Referrers API per OCI v1.1 spec #602
patrickzheng200 merged 1 commit intonotaryproject:mainfrom
patrickzheng200:referrers

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

This PR: when storing signature using oci image manifest, the Referrers API will be used. If Referrers API is not supported, automatically fallback to use Referrers Tag Schema.

Resolves #575.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #602 (b717d0e) into main (124c6c8) will increase coverage by 0.09%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   34.36%   34.45%   +0.09%     
==========================================
  Files          32       32              
  Lines        1848     1843       -5     
==========================================
  Hits          635      635              
+ Misses       1192     1187       -5     
  Partials       21       21              
Impacted Files Coverage Δ
cmd/notation/registry.go 16.78% <0.00%> (+0.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM. Just a question: why notation need to detect the support status of referrer API? Shouldn't it be automatically taken care of from oras-go side?

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200
Copy link
Copy Markdown
Contributor Author

LGTM but IANAM. Just a question: why notation need to detect the support status of referrer API? Shouldn't it be automatically taken care of from oras-go side?

Correct. The fallback logic is indeed in oras-go.

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200 patrickzheng200 merged commit 4f5f8c4 into notaryproject:main Mar 29, 2023
@patrickzheng200 patrickzheng200 deleted the referrers branch March 29, 2023 02:22
duffney pushed a commit to duffney/notation that referenced this pull request Mar 30, 2023
when storing signature using oci image manifest, the Referrers
API will be used. If Referrers API is not supported, automatically
fallback to use Referrers Tag Schema.

Signed-off-by: Josh Duffney <jduffney@microsoft.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
when storing signature using oci image manifest, the Referrers
API will be used. If Referrers API is not supported, automatically
fallback to use Referrers Tag Schema.
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
when storing signature using oci image manifest, the Referrers
API will be used. If Referrers API is not supported, automatically
fallback to use Referrers Tag Schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify referrers API when pushing image manifest

7 participants