feat: add `show` and `import` for trust policy management by qweeah · Pull Request #593 · notaryproject/notation

qweeah · 2023-03-22T07:05:18Z

This PR implements what's described in policy.md.

Resolves #548

codecov-commenter · 2023-03-22T07:17:35Z

Codecov Report

Merging #593 (f84c685) into main (56945b3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   34.45%   34.43%   -0.02%     
==========================================
  Files          32       32              
  Lines        1843     1844       +1     
==========================================
  Hits          635      635              
- Misses       1187     1188       +1     
  Partials       21       21

Impacted Files	Coverage Δ
cmd/notation/main.go	`0.00% <0.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmd/notation/policy/show.go

cmd/notation/policy/import.go

yizha1 · 2023-03-22T10:25:56Z

Suggest marking the new policy command as Preview in the output of help command.

cmd/notation/policy/import.go

test/e2e/suite/command/policy.go

qweeah · 2023-03-23T00:59:32Z

Suggest marking the new policy command as Preview in the output of help command.

Added Preview feature label. @yizha1 Do notation have or need to have any doc on the classification of work-in-progress feature labels?

yizha1 · 2023-03-23T02:59:35Z

Suggest marking the new policy command as Preview in the output of help command.

Added Preview feature label. @yizha1 Do notation have or need to have any doc on the classification of work-in-progress feature labels?

No. We need this kind of doc.

cmd/notation/policy/import.go

cmd/notation/policy/show.go

cmd/notation/policy/import.go

cmd/notation/policy/show.go

cmd/notation/policy/import.go

cmd/notation/policy/show.go

patrickzheng200

LGTM

patrickzheng200 · 2023-03-27T07:47:59Z

Lookes like the e2e test has failed.

patrickzheng200

LGTM

specs/commandline/policy.md

cmd/notation/policy/import.go

cmd/notation/policy/show.go

shizhMSFT

LGTM

cmd/notation/policy/import.go

shizhMSFT

LGTM

priteshbandi

LGTM

patrickzheng200

LGTM

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

qweeah · 2023-03-29T08:33:12Z

Hi @priteshbandi @shizhMSFT @patrickzheng200 I forget to sign the commits.

I re-signed with my GPG key and rebased, can you help review again, thanks in advance.

patrickzheng200

LGTM

shizhMSFT

LGTM

…ect#593) This PR implements what's described in [policy.md](https://github.com/notaryproject/notation/blob/18efc3de233ef5eb00e2f32009475a2b8a3eae47/specs/commandline/policy.md). Resolves notaryproject#548 Signed-off-by: Billy Zha <jinzha1@microsoft.com> Signed-off-by: Josh Duffney <jduffney@microsoft.com>

…ect#593) This PR implements what's described in [policy.md](https://github.com/notaryproject/notation/blob/18efc3de233ef5eb00e2f32009475a2b8a3eae47/specs/commandline/policy.md). Resolves notaryproject#548 Signed-off-by: Billy Zha <jinzha1@microsoft.com>

qweeah requested review from JeyJeyGao, NiazFK, SteveLasker, gokarnm, justincormack, patrickzheng200, priteshbandi, rgnote and shizhMSFT as code owners March 22, 2023 07:05

shizhMSFT reviewed Mar 22, 2023

View reviewed changes

cmd/notation/policy/show.go Outdated Show resolved Hide resolved

cmd/notation/policy/show.go Outdated Show resolved Hide resolved

cmd/notation/policy/import.go Outdated Show resolved Hide resolved

byronchien reviewed Mar 22, 2023

View reviewed changes

cmd/notation/policy/import.go Outdated Show resolved Hide resolved

test/e2e/suite/command/policy.go Outdated Show resolved Hide resolved

patrickzheng200 reviewed Mar 23, 2023

View reviewed changes

cmd/notation/policy/show.go Outdated Show resolved Hide resolved

qweeah mentioned this pull request Mar 23, 2023

add labels for features subject to changes with proper doc #596

Closed

patrickzheng200 reviewed Mar 26, 2023

View reviewed changes

patrickzheng200 reviewed Mar 27, 2023

View reviewed changes

cmd/notation/policy/import.go Outdated Show resolved Hide resolved

cmd/notation/policy/import.go Outdated Show resolved Hide resolved

cmd/notation/policy/show.go Outdated Show resolved Hide resolved

patrickzheng200 previously approved these changes Mar 27, 2023

View reviewed changes

patrickzheng200 self-requested a review March 27, 2023 07:48

qweeah dismissed patrickzheng200’s stale review via 440dea9 March 27, 2023 08:11

patrickzheng200 previously approved these changes Mar 27, 2023

View reviewed changes

qweeah dismissed patrickzheng200’s stale review via 857a2ac March 27, 2023 14:09

byronchien previously approved these changes Mar 27, 2023

View reviewed changes

qweeah commented Mar 28, 2023

View reviewed changes

specs/commandline/policy.md Show resolved Hide resolved

priteshbandi reviewed Mar 28, 2023

View reviewed changes

cmd/notation/policy/import.go Outdated Show resolved Hide resolved

cmd/notation/policy/import.go Outdated Show resolved Hide resolved

cmd/notation/policy/import.go Outdated Show resolved Hide resolved

cmd/notation/policy/show.go Outdated Show resolved Hide resolved

qweeah dismissed byronchien’s stale review via b7191c8 March 28, 2023 07:48

patrickzheng200 reviewed Mar 28, 2023

View reviewed changes

cmd/notation/policy/show.go Outdated Show resolved Hide resolved

patrickzheng200 mentioned this pull request Mar 28, 2023

chore: update err msg for policy verification notaryproject/notation-go#294

Merged

shizhMSFT previously approved these changes Mar 28, 2023

View reviewed changes

cmd/notation/policy/import.go Outdated Show resolved Hide resolved

qweeah dismissed shizhMSFT’s stale review via 13e6481 March 28, 2023 12:11

shizhMSFT previously approved these changes Mar 28, 2023

View reviewed changes

byronchien previously approved these changes Mar 28, 2023

View reviewed changes

priteshbandi previously approved these changes Mar 28, 2023

View reviewed changes

patrickzheng200 previously approved these changes Mar 29, 2023

View reviewed changes

feat: add show and import for trust policy management

f84c685

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

qweeah dismissed stale reviews from patrickzheng200, priteshbandi, byronchien, and shizhMSFT via f84c685 March 29, 2023 08:29

qweeah force-pushed the policy branch from fa8ff89 to f84c685 Compare March 29, 2023 08:29

qweeah requested review from patrickzheng200, priteshbandi and shizhMSFT and removed request for patrickzheng200, priteshbandi and shizhMSFT March 29, 2023 08:31

patrickzheng200 approved these changes Mar 29, 2023

View reviewed changes

priteshbandi approved these changes Mar 29, 2023

View reviewed changes

shizhMSFT approved these changes Mar 30, 2023

View reviewed changes

shizhMSFT merged commit 0ec3b3d into notaryproject:main Mar 30, 2023

Conversation

qweeah commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yizha1 commented Mar 22, 2023

Uh oh!

Uh oh!

Uh oh!

qweeah commented Mar 23, 2023

Uh oh!

yizha1 commented Mar 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

patrickzheng200 left a comment

Choose a reason for hiding this comment

Uh oh!

patrickzheng200 commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickzheng200 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

priteshbandi left a comment

Choose a reason for hiding this comment

Uh oh!

patrickzheng200 left a comment

Choose a reason for hiding this comment

Uh oh!

qweeah commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickzheng200 left a comment

Choose a reason for hiding this comment

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

qweeah commented Mar 22, 2023 •

edited

Loading

codecov-commenter commented Mar 22, 2023 •

edited

Loading

patrickzheng200 commented Mar 27, 2023 •

edited

Loading

qweeah commented Mar 29, 2023 •

edited

Loading