Skip to content

doc: add an example to CLI help info for notation sign#585

Merged
priteshbandi merged 1 commit intonotaryproject:mainfrom
FeynmanZhou:example
Apr 21, 2023
Merged

doc: add an example to CLI help info for notation sign#585
priteshbandi merged 1 commit intonotaryproject:mainfrom
FeynmanZhou:example

Conversation

@FeynmanZhou
Copy link
Copy Markdown
Member

Fix #584

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #585 (a9a0c43) into main (17d3525) will increase coverage by 0.09%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   33.06%   33.16%   +0.09%     
==========================================
  Files          32       32              
  Lines        2011     2014       +3     
==========================================
+ Hits          665      668       +3     
  Misses       1324     1324              
  Partials       22       22              
Impacted Files Coverage Δ
cmd/notation/sign.go 41.79% <100.00%> (+1.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kody-kimberl
kody-kimberl previously approved these changes Apr 13, 2023
Copy link
Copy Markdown
Contributor

@kody-kimberl kody-kimberl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Apr 19, 2023
Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 225ff17 into notaryproject:main Apr 21, 2023
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
FeynmanZhou added a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an example to CLI help info for notation signing

6 participants