doc: update to support OCI image manifest#502
doc: update to support OCI image manifest#502patrickzheng200 merged 10 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #502 +/- ##
=======================================
Coverage 29.57% 29.57%
=======================================
Files 26 26
Lines 1515 1515
=======================================
Hits 448 448
Misses 1050 1050
Partials 17 17 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
requested review from
FeynmanZhou,
iamsamirzon,
priteshbandi,
toddysm and
vaninrao10
Signed-off-by: Yi Zha <yizha1@microsoft.com>
specs/commandline/sign.md
Outdated
| --plugin-config strings {key}={value} pairs that are passed as it is to a plugin, refer plugin's documentation to set appropriate values | ||
| --signature-format string signature envelope format, options: 'jws', 'cose' (default "jws") | ||
| -u, --username string username for registry operations (default to $NOTATION_USERNAME if not specified) | ||
| --use-image-manifest optional for using OCI image manifest to store signatures in a registry |
There was a problem hiding this comment.
should we use some user friendly name here instead of internal implementation? like --use-oci-1.1 to reflect that if registry support oci1.1 add this flag ?
I know its not a good name but I'm open to suggestions
There was a problem hiding this comment.
@shizhMSFT @FeynmanZhou any suggestions on the flag name?
There was a problem hiding this comment.
how about the pattern --image-spec <version>-<manifest type> @priteshbandi
---image-spec string specify the manifest type for signatures. options: v1.1-artifact, v1.1-image (default: v1.1-artifact)
There was a problem hiding this comment.
+1. ORAS CLI uses --image -spec <spec version>-<manifest type> for this kind of scenario.
There was a problem hiding this comment.
yeah --image-spec looks good to me.
@iamsamirzon would like to get your opinion here
Signed-off-by: Yi Zha <yizha1@microsoft.com>
|
@yizha1 Looks like this PR requires resolving conflicts now. |
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
7 participants
Updates:
Signed-off-by: Yi Zha yizha1@microsoft.com