Skip to content

test: e2e sign/verify/trustpolicy test cases#496

Merged
shizhMSFT merged 4 commits intonotaryproject:mainfrom
JeyJeyGao:test/e2e_sign_verify
Feb 3, 2023
Merged

test: e2e sign/verify/trustpolicy test cases#496
shizhMSFT merged 4 commits intonotaryproject:mainfrom
JeyJeyGao:test/e2e_sign_verify

Conversation

@JeyJeyGao
Copy link
Copy Markdown
Contributor

Please follow the order to review: #493 -> #494 -> this PR

  • Added sign test cases
  • Added old notation forward compatibility test

Signed-off-by: Junjie Gao junjiegao@microsoft.com

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #496 (d41e602) into main (d16aff1) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   29.61%   29.61%           
=======================================
  Files          26       26           
  Lines        1513     1513           
=======================================
  Hits          448      448           
  Misses       1048     1048           
  Partials       17       17           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JeyJeyGao JeyJeyGao changed the title test: e2e sign test cases test: e2e sign/verify/trustpolicy test cases Jan 3, 2023
Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of Jan. 2023, we are going to support two combinations in Notaiton, namely:

  1. OCI artifact manifest + Referrers API
  2. OCI image manifest + Image Index

We should also have e2e test cases for Sign/Verify to cover the above scenario. Basically, it's more related to the Sign process. For example, we can have a registry in e2e that supports OCI artifact manifest but not Referrers api such as Docker hub, Sign would then be expected to fail.
On the other hand, we could also have a registry which doesn't support OCI artifact manifest nor Referrers api, but if we enable the OCI image manifest flag, Sign would be expected to success. (We can include these test cases in a future PR though if it's more preferrable)

@JeyJeyGao JeyJeyGao force-pushed the test/e2e_sign_verify branch from ba5142b to 1c3c214 Compare January 29, 2023 09:35
Copy link
Copy Markdown
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200
Copy link
Copy Markdown
Contributor

Do we have a test case that's covering For a given artifact there MUST be only one applicable trust policy, except for trust policy with global scope.? (Basically, we could create an invalid trustpolicy document with two statements sharing the same registry scope.)

@JeyJeyGao
Copy link
Copy Markdown
Contributor Author

Do we have a test case that's covering For a given artifact there MUST be only one applicable trust policy, except for trust policy with global scope.? (Basically, we could create an invalid trustpolicy document with two statements sharing the same registry scope.)

Added multi-statements trust policy test cases

Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao force-pushed the test/e2e_sign_verify branch from 435699e to e192bfa Compare February 2, 2023 01:28
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao force-pushed the test/e2e_sign_verify branch from e192bfa to 73502e8 Compare February 3, 2023 10:00
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao force-pushed the test/e2e_sign_verify branch from 73502e8 to d41e602 Compare February 3, 2023 10:02
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2581807 into notaryproject:main Feb 3, 2023
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
- Added sign test cases
- Added old notation forward compatibility test

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
- Added sign test cases
- Added old notation forward compatibility test

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants