Skip to content

cleanup: clean up notation CLI#485

Merged
priteshbandi merged 10 commits intonotaryproject:mainfrom
patrickzheng200:cleanup
Dec 20, 2022
Merged

cleanup: clean up notation CLI#485
priteshbandi merged 10 commits intonotaryproject:mainfrom
patrickzheng200:cleanup

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

This PR intends to resolve #446, #477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 self-assigned this Dec 14, 2022
@patrickzheng200 patrickzheng200 added the triage Need to triage label Dec 14, 2022
@patrickzheng200 patrickzheng200 added this to the RC-2 milestone Dec 14, 2022
@patrickzheng200 patrickzheng200 linked an issue Dec 14, 2022 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #485 (92b16a5) into main (b8ce43a) will decrease coverage by 0.53%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   32.33%   31.80%   -0.54%     
==========================================
  Files          25       25              
  Lines        1336     1327       -9     
==========================================
- Hits          432      422      -10     
- Misses        892      893       +1     
  Partials       12       12              
Impacted Files Coverage Δ
cmd/notation/verify.go 27.00% <0.00%> (-0.28%) ⬇️
internal/envelope/envelope.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 2 commits December 19, 2022 19:56
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 6346a87 into notaryproject:main Dec 20, 2022
@patrickzheng200 patrickzheng200 deleted the cleanup branch December 20, 2022 06:30
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 5, 2023
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Need to triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider more verbose error messages by default Deadcode cleanup improvement Notation

4 participants