Skip to content

Fix: fixed notation cert command#483

Merged
priteshbandi merged 7 commits intonotaryproject:mainfrom
patrickzheng200:fix_cert
Dec 20, 2022
Merged

Fix: fixed notation cert command#483
priteshbandi merged 7 commits intonotaryproject:mainfrom
patrickzheng200:fix_cert

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 commented Dec 13, 2022

Before adding a file into the trust store using notation cert add, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to the notation cert list command.

This PR fixes #482.

fixed notation cert command
9f84a80 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 self-assigned this Dec 13, 2022
@patrickzheng200 patrickzheng200 added the bug Something isn't working label Dec 13, 2022
@patrickzheng200 patrickzheng200 added this to the RC-2 milestone Dec 13, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 13, 2022 •
edited
Loading

Codecov Report

Merging #483 (035971a) into main (7a947d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   32.14%   32.14%           
=======================================
  Files          25       25           
  Lines        1341     1341           
=======================================
  Hits          431      431           
  Misses        898      898           
  Partials       12       12

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JeyJeyGao
JeyJeyGao approved these changes Dec 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi reviewed Dec 14, 2022
View reviewed changes
Patrick Zheng added 2 commits December 19, 2022 17:24
update per code review
035971a 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added unit test
a4f78fa 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
shizhMSFT reviewed Dec 19, 2022
View reviewed changes
Patrick Zheng added 3 commits December 19, 2022 18:32
Merge branch 'notaryproject:main' into fix_cert
8016e28
update per code review
2f3dd69 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
fixed unit test
6962d31 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Dec 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi reviewed Dec 20, 2022
View reviewed changes
priteshbandi
priteshbandi approved these changes Dec 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 4a4a820 into notaryproject:main Dec 20, 2022
@patrickzheng200 patrickzheng200 deleted the fix_cert branch December 20, 2022 06:30
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@vaninrao10
Fix: fixed notation cert command (notaryproject#483)
274fbfb 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@vaninrao10
Fix: fixed notation cert command (notaryproject#483)
1c88bb1 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@vaninrao10
Fix: fixed notation cert command (notaryproject#483)
79d8576 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@vaninrao10
Fix: fixed notation cert command (notaryproject#483)
2c4e9f8 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@vaninrao10
Fix: fixed notation cert command (notaryproject#483)
3e8eba2 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@vaninrao10
Fix: fixed notation cert command (notaryproject#483)
c6dac2d 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 5, 2023
@vaninrao10
Fix: fixed notation cert command (notaryproject#483)
e50fa31 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
@7h3-3mp7y-m4n
Fix: fixed notation cert command (notaryproject#483)
2d0e86e 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
@FeynmanZhou
Fix: fixed notation cert command (notaryproject#483)
53397e5 
Before adding a file into the trust store using `notation cert add`,
notation CLI would check if it's valid first. Only file containing valid
certificate(s) will be added. Same rule applies to the `notation cert
list` command.

This PR fixes notaryproject#482.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

+1 more reviewer

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickzheng200 patrickzheng200

Labels

bug Something isn't working

Projects

None yet

Milestone

RC-2

Development

Successfully merging this pull request may close these issues.

Notation CLI: can add an empty .docx file into the trust store and list it

5 participants

@patrickzheng200 @codecov-commenter @priteshbandi @shizhMSFT @JeyJeyGao