Fix artifactType for notary project signatures#471
Closed
sajayantony wants to merge 1 commit intonotaryproject:mainfrom
Closed
Fix artifactType for notary project signatures#471sajayantony wants to merge 1 commit intonotaryproject:mainfrom
sajayantony wants to merge 1 commit intonotaryproject:mainfrom
Conversation
The artifactType is defined in https://github.com/notaryproject/notaryproject/blob/efc828223710f99ab9639d2d0f72d59036a8e80c/specs/signature-specification.md#storage Signed-off-by: Sajay Antony <sajaya@microsoft.com>
sajayantony
force-pushed
the
mediaType
branch
from
4051778 to
4e65cc7
Compare
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 32.26% 32.26%
=======================================
Files 25 25
Lines 1336 1336
=======================================
Hits 431 431
Misses 893 893
Partials 12 12 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4 tasks
Contributor
|
Closing this PR as the changes have been conveyed by #468. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The artifactType is defined in https://github.com/notaryproject/notaryproject/blob/efc828223710f99ab9639d2d0f72d59036a8e80c/specs/signature-specification.md#storage
Th aligns with the PR notaryproject/notation-go#230