Skip to content

update: cleaned up dead code in CLI#464

Merged
priteshbandi merged 1 commit intonotaryproject:mainfrom
patrickzheng200:cleanup
Dec 5, 2022
Merged

update: cleaned up dead code in CLI#464
priteshbandi merged 1 commit intonotaryproject:mainfrom
patrickzheng200:cleanup

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

Cleaned up dead code in notation CLI

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 self-assigned this Dec 5, 2022
@patrickzheng200 patrickzheng200 added this to the RC-1 milestone Dec 5, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #464 (8c4a2dc) into main (767f8ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   32.40%   32.40%           
=======================================
  Files          25       25           
  Lines        1290     1290           
=======================================
  Hits          418      418           
  Misses        860      860           
  Partials       12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 0af4a82 into notaryproject:main Dec 5, 2022
@patrickzheng200 patrickzheng200 deleted the cleanup branch December 5, 2022 06:15
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Cleaned up dead code in notation CLI

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Cleaned up dead code in notation CLI

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants