update: updated plugin list command#461
Merged
shizhMSFT merged 33 commits intonotaryproject:mainfrom Dec 2, 2022
Merged
Conversation
added 26 commits
October 12, 2022 11:02
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
changed the title
shizhMSFT
reviewed
Dec 1, 2022
added 4 commits
December 1, 2022 17:02
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 32.48% 32.22% -0.26%
==========================================
Files 25 25
Lines 1250 1260 +10
==========================================
Hits 406 406
- Misses 832 842 +10
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shizhMSFT
reviewed
Dec 1, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
priteshbandi
approved these changes
Dec 2, 2022
Contributor
priteshbandi
left a comment
priteshbandi
left a comment
There was a problem hiding this comment.
LGTM with suggestions
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Dec 2, 2022
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
This PR mainly fixed the plugin list command. Previously, if there's an error on getting a plugin, only the error will be printed out. In this PR, on error, the pluginName will also be printed out along with the error. (This PR also includes some of the minor cleanups of notation CLI.) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
This PR mainly fixed the plugin list command. Previously, if there's an error on getting a plugin, only the error will be printed out. In this PR, on error, the pluginName will also be printed out along with the error. (This PR also includes some of the minor cleanups of notation CLI.) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly fixed the plugin list command.
Previously, if there's an error on getting a plugin, only the error will be printed out.
In this PR, on error, the pluginName will also be printed out along with the error.
(This PR also includes some of the minor cleanups of notation CLI.)
Signed-off-by: Patrick Zheng patrickzheng@microsoft.com