feat: add `--debug` & `--verbose` flags & http request/response debug log by JeyJeyGao · Pull Request #457 · notaryproject/notation

JeyJeyGao · 2022-11-28T08:03:03Z

added debug flag for sign/verify commands
added verbose flag for sign/verify commands
added http request/response debug log

Signed-off-by: Junjie Gao junjiegao@microsoft.com

internal/trace/transport.go

internal/trace/context.go

internal/cmd/options.go

internal/trace/context.go

codecov-commenter · 2022-11-30T04:35:24Z

Codecov Report

Merging #457 (145daab) into main (0af4a82) will decrease coverage by 0.29%.
The diff coverage is 6.81%.

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   32.40%   32.10%   -0.30%     
==========================================
  Files          25       25              
  Lines        1290     1305      +15     
==========================================
+ Hits          418      419       +1     
- Misses        860      874      +14     
  Partials       12       12

Impacted Files	Coverage Δ
cmd/notation/list.go	`23.28% <0.00%> (ø)`
cmd/notation/login.go	`42.68% <0.00%> (ø)`
cmd/notation/manifest.go	`0.00% <0.00%> (ø)`
cmd/notation/registry.go	`0.00% <0.00%> (ø)`
cmd/notation/sign.go	`43.18% <14.28%> (-1.53%)`	⬇️
cmd/notation/verify.go	`29.03% <18.18%> (+1.37%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

internal/cmd/options.go

cmd/notation/sign.go

internal/cmd/options.go

cmd/notation/verify.go

internal/cmd/options.go

internal/trace/context.go

internal/ioutil/print.go

cmd/notation/registry.go

internal/cmd/options.go

cmd/notation/registry.go

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

patrickzheng200

LGTM

internal/trace/transport.go

internal/trace/context.go

internal/trace/transport.go

cmd/notation/registry.go

internal/trace/transport.go

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

cmd/notation/registry.go

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

priteshbandi

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

cmd/notation/registry.go

internal/cmd/options.go

internal/trace/context.go

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

patrickzheng200

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

shizhMSFT

LGTM

… log (notaryproject#457) - added debug flag for sign/verify commands - added verbose flag for sign/verify commands - added http request/response debug log Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

github-advanced-security bot found potential problems Nov 28, 2022

View reviewed changes

internal/trace/transport.go Fixed Show fixed Hide fixed

yizha1 reviewed Nov 28, 2022

View reviewed changes

internal/trace/context.go Show resolved Hide resolved

patrickzheng200 reviewed Nov 28, 2022

View reviewed changes

internal/cmd/options.go Outdated Show resolved Hide resolved

internal/cmd/options.go Show resolved Hide resolved

patrickzheng200 reviewed Nov 29, 2022

View reviewed changes

internal/trace/context.go Outdated Show resolved Hide resolved

JeyJeyGao force-pushed the feat/add_debug branch 2 times, most recently from 8988dec to acb73ce Compare November 30, 2022 04:32

JeyJeyGao force-pushed the feat/add_debug branch from 5a05997 to f3430b9 Compare December 1, 2022 05:21

patrickzheng200 reviewed Dec 1, 2022

View reviewed changes

internal/cmd/options.go Outdated Show resolved Hide resolved

JeyJeyGao force-pushed the feat/add_debug branch from f3430b9 to e1fef52 Compare December 1, 2022 05:57

patrickzheng200 reviewed Dec 1, 2022

View reviewed changes

cmd/notation/sign.go Show resolved Hide resolved

cmd/notation/sign.go Outdated Show resolved Hide resolved

internal/cmd/options.go Outdated Show resolved Hide resolved

cmd/notation/verify.go Show resolved Hide resolved

patrickzheng200 reviewed Dec 1, 2022

View reviewed changes

internal/cmd/options.go Outdated Show resolved Hide resolved

JeyJeyGao force-pushed the feat/add_debug branch 2 times, most recently from 30a9b05 to 92625e9 Compare December 1, 2022 08:16

JeyJeyGao requested review from priteshbandi and shizhMSFT December 1, 2022 13:56

JeyJeyGao force-pushed the feat/add_debug branch from 92625e9 to cc71876 Compare December 1, 2022 15:19

shizhMSFT reviewed Dec 1, 2022

View reviewed changes

internal/trace/context.go Show resolved Hide resolved

internal/ioutil/print.go Outdated Show resolved Hide resolved

cmd/notation/registry.go Outdated Show resolved Hide resolved

JeyJeyGao force-pushed the feat/add_debug branch from cc71876 to d5d5c87 Compare December 2, 2022 03:43

JeyJeyGao changed the title ~~feat: add http request/response debug log~~ feat: add --debug & --verbose flag & http request/response debug log Dec 2, 2022

JeyJeyGao force-pushed the feat/add_debug branch from d5d5c87 to 2245669 Compare December 2, 2022 03:51

JeyJeyGao changed the title ~~feat: add --debug & --verbose flag & http request/response debug log~~ feat: add --debug & --verbose flags & http request/response debug log Dec 2, 2022

priteshbandi reviewed Dec 2, 2022

View reviewed changes

internal/cmd/options.go Show resolved Hide resolved

cmd/notation/registry.go Outdated Show resolved Hide resolved

JeyJeyGao force-pushed the feat/add_debug branch from 81e9edd to f88d524 Compare December 2, 2022 08:11

JeyJeyGao added 6 commits December 2, 2022 16:17

feat: update log

f0fd009

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update log

d8c6190

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: resolve comments

149d25c

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: resolve comments

415eab7

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

feat: add verbose flag

b673b1c

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: resolve comment

f3b2d7f

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update to refactor set http debug log

7caa240

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao force-pushed the feat/add_debug branch from cd5d4a8 to 7caa240 Compare December 2, 2022 14:07

patrickzheng200 approved these changes Dec 2, 2022

View reviewed changes

github-advanced-security bot found potential problems Dec 2, 2022

View reviewed changes

internal/trace/transport.go Fixed Show fixed Hide fixed

JeyJeyGao force-pushed the feat/add_debug branch from 89eb4d8 to 7caa240 Compare December 2, 2022 15:45

shizhMSFT reviewed Dec 2, 2022

View reviewed changes

priteshbandi reviewed Dec 3, 2022

View reviewed changes

internal/trace/transport.go Show resolved Hide resolved

JeyJeyGao force-pushed the feat/add_debug branch 2 times, most recently from f8c7583 to d696d55 Compare December 5, 2022 02:28

fix: resolve comments

a75b525

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao force-pushed the feat/add_debug branch from d696d55 to a75b525 Compare December 5, 2022 02:49

shizhMSFT reviewed Dec 5, 2022

View reviewed changes

cmd/notation/registry.go Outdated Show resolved Hide resolved

cmd/notation/registry.go Outdated Show resolved Hide resolved

cmd/notation/registry.go Outdated Show resolved Hide resolved

JeyJeyGao added 4 commits December 5, 2022 13:05

fix: resolve comments

fb48cda

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Merge remote-tracking branch 'upstream/main' into feat/add_debug

d40a93e

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Merge remote-tracking branch 'upstream/main' into feat/add_debug

451f681

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: optimize getRepository

3d021c2

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

priteshbandi approved these changes Dec 5, 2022

View reviewed changes

fix: optimize setHttpDebugLog

8dd7d50

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao force-pushed the feat/add_debug branch from 55630b3 to 8dd7d50 Compare December 5, 2022 06:51

shizhMSFT reviewed Dec 5, 2022

View reviewed changes

cmd/notation/registry.go Outdated Show resolved Hide resolved

patrickzheng200 reviewed Dec 5, 2022

View reviewed changes

internal/cmd/options.go Outdated Show resolved Hide resolved

internal/trace/context.go Outdated Show resolved Hide resolved

fix: resolve comments

4f04ea8

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

patrickzheng200 approved these changes Dec 5, 2022

View reviewed changes

JeyJeyGao added 2 commits December 5, 2022 15:19

fix: resolve comments

c789f57

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: resolve comment

994a564

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao force-pushed the feat/add_debug branch from 145daab to 994a564 Compare December 5, 2022 08:13

shizhMSFT approved these changes Dec 5, 2022

View reviewed changes

shizhMSFT merged commit e6b2e8c into notaryproject:main Dec 5, 2022

Conversation

JeyJeyGao commented Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

patrickzheng200 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

priteshbandi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

patrickzheng200 left a comment

Choose a reason for hiding this comment

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

JeyJeyGao commented Nov 28, 2022 •

edited

Loading

codecov-commenter commented Nov 30, 2022 •

edited

Loading