Skip to content

doc: update CLI help doc for notation sign and verify in RC.1#454

Merged
priteshbandi merged 17 commits intonotaryproject:mainfrom
FeynmanZhou:main
Dec 2, 2022
Merged

doc: update CLI help doc for notation sign and verify in RC.1#454
priteshbandi merged 17 commits intonotaryproject:mainfrom
FeynmanZhou:main

Conversation

@FeynmanZhou
Copy link
Copy Markdown
Member

@FeynmanZhou FeynmanZhou commented Nov 25, 2022

fix #383

FeynmanZhou and others added 16 commits June 1, 2022 18:56
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #454 (4755060) into main (53052a9) will increase coverage by 0.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   32.82%   33.46%   +0.64%     
==========================================
  Files          25       25              
  Lines        1237     1249      +12     
==========================================
+ Hits          406      418      +12     
  Misses        819      819              
  Partials       12       12              
Impacted Files Coverage Δ
cmd/notation/sign.go 39.17% <100.00%> (+1.94%) ⬆️
cmd/notation/verify.go 33.76% <100.00%> (+8.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou requested a review from yizha1 November 25, 2022 15:27
@FeynmanZhou FeynmanZhou added documentation Improvements or additions to documentation UX User experience changes labels Nov 25, 2022
Copy link
Copy Markdown
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit a6e6fa0 into notaryproject:main Dec 2, 2022
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
FeynmanZhou added a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation UX User experience changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add examples for notation command help doc

5 participants