Skip to content

Feature/issue templates#435

Merged
toddysm merged 15 commits intonotaryproject:mainfrom
toddysm:feature/issue-templates
Nov 10, 2022
Merged

Feature/issue templates#435
toddysm merged 15 commits intonotaryproject:mainfrom
toddysm:feature/issue-templates

Conversation

@toddysm
Copy link
Copy Markdown
Contributor

@toddysm toddysm commented Nov 5, 2022

Added bug and feature request templates. We should merge those to main so they can become available for users to file issues. Current experience goes to the discussion board.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 5, 2022

Codecov Report

Merging #435 (3babf65) into main (ed5beb8) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   32.95%   32.82%   -0.14%     
==========================================
  Files          25       25              
  Lines        1232     1237       +5     
==========================================
  Hits          406      406              
- Misses        814      819       +5     
  Partials       12       12              
Impacted Files Coverage Δ
pkg/configutil/util.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddysm toddysm force-pushed the feature/issue-templates branch from 23d32b9 to 2704f5c Compare November 5, 2022 03:23
@FeynmanZhou
Copy link
Copy Markdown
Member

@toddysm The question lists look good to me.
Do you think create an issue form is more convenient than a text-based issue template? This is a new style of issue template provided by GitHub.

See an example in the ORAS issue form.

@FeynmanZhou FeynmanZhou self-requested a review November 5, 2022 04:05
@toddysm
Copy link
Copy Markdown
Contributor Author

toddysm commented Nov 7, 2022

The form looks like a better approach. Let me update the free text to a form and update the PR.

@FeynmanZhou
Copy link
Copy Markdown
Member

The form looks like a better approach. Let me update the free text to a form and update the PR.

@toddysm Thanks. I could help it if needed.

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@toddysm toddysm force-pushed the feature/issue-templates branch from aa62f75 to cedff80 Compare November 8, 2022 22:41
@toddysm
Copy link
Copy Markdown
Contributor Author

toddysm commented Nov 8, 2022

@FeynmanZhou This is updated... Please take another look

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

Comment on lines +55 to +56
validations:
required: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove this as user might not have any additional context to share.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this can be optional.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priteshbandi I changed to false. Can you approve again?

Copy link
Copy Markdown
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@toddysm toddysm merged commit ca9edd0 into notaryproject:main Nov 10, 2022
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Added bug and feature request templates. We should merge those to main
so they can become available for users to file issues. Current
experience goes to the discussion board.

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Added bug and feature request templates. We should merge those to main
so they can become available for users to file issues. Current
experience goes to the discussion board.

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants