Skip to content

Improve error message when default signing key is not set#432

Merged
shizhMSFT merged 2 commits intonotaryproject:mainfrom
priteshbandi:fix
Nov 7, 2022
Merged

Improve error message when default signing key is not set#432
shizhMSFT merged 2 commits intonotaryproject:mainfrom
priteshbandi:fix

Conversation

@priteshbandi
Copy link
Copy Markdown
Contributor

Fixes Issue: #410

Test output

➜  notation git:(fix) ✗ ./notation key ls
NAME   KEY PATH   CERTIFICATE PATH   ID   PLUGIN NAME
➜  notation git:(fix) ✗ ./notation sign --plain-http $IMAGE
Error: default signing key not set. Please set default singing key or specify a key name

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #432 (d86b039) into main (ed5beb8) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   32.95%   32.82%   -0.14%     
==========================================
  Files          25       25              
  Lines        1232     1237       +5     
==========================================
  Hits          406      406              
- Misses        814      819       +5     
  Partials       12       12              
Impacted Files Coverage Δ
pkg/configutil/util.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 40973f9 into notaryproject:main Nov 7, 2022
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants