feat: Added notation certificate command for trust store#405
Merged
shizhMSFT merged 50 commits intonotaryproject:mainfrom Oct 31, 2022
Merged
feat: Added notation certificate command for trust store#405shizhMSFT merged 50 commits intonotaryproject:mainfrom
notation certificate command for trust store#405shizhMSFT merged 50 commits intonotaryproject:mainfrom
Conversation
added 18 commits
October 12, 2022 11:02
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 33.84% 32.95% -0.90%
==========================================
Files 21 25 +4
Lines 1105 1232 +127
==========================================
+ Hits 374 406 +32
- Misses 722 814 +92
- Partials 9 12 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chloeyin
reviewed
Oct 19, 2022
chloeyin
reviewed
Oct 19, 2022
added 4 commits
October 20, 2022 10:11
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added 2 commits
October 31, 2022 11:10
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
force-pushed
the
truststore
branch
from
27b21e3 to
469069e
Compare
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added 3 commits
October 31, 2022 14:49
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
force-pushed
the
truststore
branch
from
c36ee92 to
a08dc9e
Compare
added 2 commits
October 31, 2022 16:07
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
requested changes
Oct 31, 2022
|
|
||
| if opts.all { | ||
| // Delete all certificates under storeType/namedStore | ||
| errorSlice = truststore.DeleteAllCerts(storeType, namedStore, opts.confirmed, errorSlice) |
Contributor
There was a problem hiding this comment.
errorSlice is []error. We can define a type type Errors []error and implement func (errs Error) Error string() to reduce duplicated code. This can be done later in the notation CLI code refactoring. Of course, we need an issue to track.
patrickzheng200
force-pushed
the
truststore
branch
from
63bd098 to
8d1d4dc
Compare
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added 2 commits
October 31, 2022 20:46
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
…ject#405) This PR is the implementation of `notation certificate` command regarding the use of trust store. Based on community meeting, this command only effects on User level. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
…ject#405) This PR is the implementation of `notation certificate` command regarding the use of trust store. Based on community meeting, this command only effects on User level. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the implementation of
notation certificatecommand regarding the use of trust store.Based on community meeting, this command only effects on User level.
Signed-off-by: Patrick Zheng patrickzheng@microsoft.com